Skip to content

[stable2412] Backport #9195#9403

Merged
EgorPopelyaev merged 2 commits intostable2412from
backport-9195-to-stable2412
Aug 20, 2025
Merged

[stable2412] Backport #9195#9403
EgorPopelyaev merged 2 commits intostable2412from
backport-9195-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

@paritytech-release-backport-bot paritytech-release-backport-bot bot commented Jul 31, 2025

Backport #9195 into stable2412 from karolk91.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

paritytech-release-backport-bot bot commented Jul 31, 2025

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-9195-to-stable2412
git worktree add --checkout .worktree/backport-9195-to-stable2412 backport-9195-to-stable2412
cd .worktree/backport-9195-to-stable2412
git reset --hard HEAD^
git cherry-pick -x d9f451a6b94ab2cf39371ee5192130379eb6e199
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Jul 31, 2025
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jul 31, 2025
@github-actions github-actions bot requested a review from karolk91 July 31, 2025 11:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 31, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@karolk91 @github-actions @acatangiu
XCMv5 asset exchange test scenarios (#9195)
2250db8 
Relates to: #9093
Requires: #9179

This PR introduces emulated test scenarios:

(Penpal -> AH -> Penpal) to showcase usage of remote `Transact` to swap
assets remotely on AssetHub while also making use of
`add_authorized_alias`, to transact as Sender on remote side (instead of
Senders sovereign account).

1. Prepare sovereign accounts funds, create pools, prepare aliasing
rules
2. Send WND from Penpal to AssetHub (AH being remote reserve for WND)
3. Alias into sender account and exchange WNDs for USDT using `Transact`
with `swap_tokens_for_exact_tokens` call inside
4. Send USDT and leftover WND back to Penpal

(Penpal -> AH -> Penpal) to showcase usage of remote `Transact` to swap
assets remotely on AssetHub.

1. Prepare sovereign accounts funds, create pools, prepare aliasing
rules
2. Send WND from Penpal to AssetHub (AH being remote reserve for WND)
3. Exchange WNDs for USDT using `Transact` with
`swap_tokens_for_exact_tokens` call inside
4. Send USDT and leftover WND back to Penpal

(Penpal -> AH -> Penpal) to showcase same as above but this time using
`ExchangeAsset` XCM instruction instead of `Transact`:

1. Prepare sovereign accounts funds, create pools
2. Send WND from Penpal to AssetHub (AH being remote reserve for WND)
3. Exchange WNDs for USDT using `ExchangeAsset`
4. Send USDT and leftover WND back to Penpal

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
(cherry picked from commit d9f451a)
@karolk91 karolk91 force-pushed the backport-9195-to-stable2412 branch from 9bc76e3 to 2250db8 Compare July 31, 2025 13:38
@karolk91 karolk91 marked this pull request as ready for review July 31, 2025 13:42
@karolk91 karolk91 requested a review from a team as a code owner July 31, 2025 13:42
@karolk91
Copy link
Copy Markdown
Contributor

karolk91 commented Jul 31, 2025 •
edited
Loading

Differences to the original PR because of differences between stable2412 vs newer releases:

  • doesn't have support for aliases (add_authorized_alias etc.) so I've removed the scenario transact_using_authorized_alias_from_para_to_asset_hub_and_back_to_para as it doesn't apply here
  • xcm-pallet doesn't emit Sent event (EventEmitter was never backported) so usage of TopicIdTracker is limited to Processed events only

@acatangiu
Copy link
Copy Markdown
Contributor

acatangiu commented Jul 31, 2025

since this is just there is also no strong reason to backport so up to you

@karolk91
Copy link
Copy Markdown
Contributor

karolk91 commented Aug 1, 2025

since this is just there is also no strong reason to backport so up to you

I think that as long as we support this branch, we should also aim to have better test coverage so I think we can merge

But on this branch tests condition is bad, there are other unrelated tests failing:

  TRY 6 FAIL [  20.969s] pallet-revive-eth-rpc tests::test_jsonrpsee_server
  TRY 6 FAIL [   0.025s] xcm-runtime-apis::fee_estimation dry_run_xcm_versions

I have fixed dry_run_xcm_versions and wondering if should make it part of this PR ? I havent really looked into test_jsonrpsee_server but I guess we should fix these to have green pipeline on stable2412

@EgorPopelyaev EgorPopelyaev merged commit 0d4b05f into stable2412 Aug 20, 2025
170 of 240 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-9195-to-stable2412 branch August 20, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karolk91 karolk91 karolk91 approved these changes

Assignees

@karolk91 karolk91

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karolk91 @acatangiu @EgorPopelyaev