Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions prdoc/pr_9355.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
title: 'substrate-prometheus-endpoint: directly require the feature "tokio/net"'
doc:
- audience: Node Dev
description: |-
The crate `substrate-prometheus-endpoint` use tokio items given by the feature "net" but it doesn't explictly requires it in the `Cargo.toml`. It compiles on master because `hyper-util` enables the feature "tokio/net". But upgrading `hyper-util` break this indirect enabling.

This fix the issue by directly setting "net" feature as required, as it is used.
We should also backport this ideally. It is not a breaking change given the code doesn't compile without the feature and only compiles if indirectly enabled by another crate.
crates:
- name: substrate-prometheus-endpoint
bump: patch
2 changes: 1 addition & 1 deletion substrate/utils/prometheus/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ hyper-util = { features = ["server-auto", "server-graceful", "tokio"], workspace
log = { workspace = true, default-features = true }
prometheus = { workspace = true }
thiserror = { workspace = true }
tokio = { features = ["parking_lot"], workspace = true, default-features = true }
tokio = { features = ["net", "parking_lot"], workspace = true, default-features = true }

[dev-dependencies]
hyper-util = { features = ["client-legacy", "tokio"], workspace = true, default-features = true }
Expand Down
Loading