Replace log with tracing on Snowbridge-related modules#9279
Merged
raymondkfcheung merged 124 commits intomasterfrom Nov 11, 2025
Merged
Replace log with tracing on Snowbridge-related modules#9279raymondkfcheung merged 124 commits intomasterfrom
log with tracing on Snowbridge-related modules#9279raymondkfcheung merged 124 commits intomasterfrom
Conversation
raymondkfcheung
changed the title
log with tracing on Bridge-related modules
24 tasks
# Conflicts: # bridges/snowbridge/pallets/ethereum-client/src/impls.rs
x3c41a
reviewed
Nov 6, 2025
| let message = Self::prepare(message)?; | ||
|
|
||
| log::trace!(target: LOG_TARGET, "prepared message: {:?}", message); | ||
| tracing::trace!(target: LOG_TARGET, ?message, "prepared message"); |
Contributor
There was a problem hiding this comment.
do we need a blank space after prepared message?
Contributor
Author
There was a problem hiding this comment.
I don't think so.
x3c41a
reviewed
Nov 6, 2025
Comment on lines
+22
to
+26
| bump: patch | ||
| - name: snowbridge-pallet-system-v2 | ||
| bump: patch | ||
| - name: snowbridge-runtime-common | ||
| bump: minor |
Contributor
There was a problem hiding this comment.
dq: how do you distinguish between minor and patch in terms of this PR?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Thanks for the link, I was not aware of it.
I looked at Validate prdoc for ... step in the link that you sent and checked the corresponding yml file with job definition; it uses check-prdoc.py underneath.
So I checked both: the script and yml job but could not find a piece of code responsible for bump validation.
Did I miss anything?
x3c41a
approved these changes
Nov 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
This PR replaces `log` with `tracing` instrumentation on Bridge Relay related modules by providing structured logging. Partially addresses #9211 Similar to #9279 ## Key Features - **Consistent targets**: All components use predictable log targets - **Structured fields**: Uses `?variable`/`%variable` syntax for automatic `Debug`/`Display` formatting - **Zero runtime impact**: No behavioural changes, only observability improvements --------- Co-authored-by: Andrii <ndk@parity.io>
acatangiu
approved these changes
Nov 11, 2025
| @@ -0,0 +1,30 @@ | |||
| title: Replace `log` with `tracing` on Snowbridge-related modules | |||
Contributor
There was a problem hiding this comment.
minor or even patch are fine
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
logwithtracinginstrumentation in Snowbridge-related modules by providing structured logging.Partially addresses #9211
Similar to #8732
Key Features
?variable/%variablesyntax for automaticDebug/Displayformatting