Skip to content

gossip-support: make low connectivity message an error #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexggh merged 6 commits into from
Jul 21, 2025
Merged

gossip-support: make low connectivity message an error #9264

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20b53c7
gossip-support: make low connectivity warning an error
alexggh Jul 18, 2025
aed2478
Update polkadot/node/network/gossip-support/src/lib.rs
alexggh Jul 18, 2025
db9a86b
add session_index
alexggh Jul 18, 2025
279630c
Update lib.rs
alexggh Jul 21, 2025
421ddb1
Update from github-actions[bot] running command 'prdoc --audience nod…
github-actions[bot] Jul 21, 2025
2f24c29
Merge branch 'master' into alexggh/low_connectivity
alexggh Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions polkadot/node/network/gossip-support/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,15 @@ const TRY_RERESOLVE_AUTHORITIES: Duration = Duration::from_secs(2);
const LOW_CONNECTIVITY_WARN_DELAY: Duration = Duration::from_secs(600);

/// If connectivity is lower than this in percent, issue warning in logs.
const LOW_CONNECTIVITY_WARN_THRESHOLD: usize = 90;
const LOW_CONNECTIVITY_WARN_THRESHOLD: usize = 85;

/// The Gossip Support subsystem.
pub struct GossipSupport<AD> {
keystore: KeystorePtr,

last_session_index: Option<SessionIndex>,
/// Whether we are currently an authority or not.
is_authority_now: bool,
/// The minimum known session we build the topology for.
min_known_session: SessionIndex,
// Some(timestamp) if we failed to resolve
Expand Down Expand Up @@ -163,6 +165,7 @@ where
min_known_session: u32::MAX,
authority_discovery,
finalized_needed_session: None,
is_authority_now: false,
metrics,
}
}
Expand Down Expand Up @@ -282,6 +285,9 @@ where
"New session detected",
);
self.last_session_index = Some(session_index);
self.is_authority_now =
ensure_i_am_an_authority(&self.keystore, &session_info.discovery_keys)
.is_ok();
}

// Connect to authorities from the past/present/future.
Expand Down Expand Up @@ -705,13 +711,11 @@ where
.resolved_authorities
.iter()
.filter(|(a, _)| !self.connected_authorities.contains_key(a));
// TODO: Make that warning once connectivity issues are fixed (no point in warning, if
// we already know it is broken.
// https://github.com/paritytech/polkadot/issues/3921
if connected_ratio <= LOW_CONNECTIVITY_WARN_THRESHOLD {
gum::debug!(
if connected_ratio <= LOW_CONNECTIVITY_WARN_THRESHOLD && self.is_authority_now {
gum::error!(
Copy link
Copy Markdown
Contributor

@AndreiEres AndreiEres Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be warn or error?

Copy link
Copy Markdown
Contributor Author

@alexggh alexggh Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went with error because I want it to not be ignored.

target: LOG_TARGET,
"Connectivity seems low, we are only connected to {}% of available validators (see debug logs for details)", connected_ratio
session_index = self.last_session_index.as_ref().map(|s| *s).unwrap_or_default(),
"Connectivity seems low at, we are only connected to {connected_ratio}% of available validators (see debug logs for details), if this persists more than a session action needs to be taken"
);
}
let pretty = PrettyAuthorities(unconnected_authorities);
Expand Down
Loading