Skip to content

WIP: apply_dynamic_fee_factor with asset: &mut Asset #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkontur merged 2 commits into from
Jul 18, 2025
Merged

WIP: apply_dynamic_fee_factor with asset: &mut Asset #9259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
179377e
apply_dynamic_fee_factor with `asset: &mut Asset`
bkontur Jul 18, 2025
e0750a0
Nit
serban300 Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions bridges/modules/xcm-bridge-router/src/impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ where
// required.
if let Some(bridge_id) = T::BridgeIdResolver::resolve_for(network, remote_location) {
if let Some(bridge_state) = Bridges::<T, I>::get(bridge_id) {
if let Some(f) = fees {
fees = Some(Pallet::<T, I>::apply_dynamic_fee_factor(&bridge_state, f));
if let Some(f) = fees.as_mut() {
Pallet::<T, I>::apply_dynamic_fee_factor(&bridge_state, f);
}
}
}
Expand Down Expand Up @@ -217,10 +217,9 @@ impl<T: Config<I>, I: 'static, E: SendXcm> SendXcm for ViaLocalBridgeExporter<T,
// check/apply the congestion and dynamic_fees features (if possible).
if let Some(bridge_id) = T::BridgeIdResolver::resolve_for_dest(&dest_clone) {
if let Some(bridge_state) = Bridges::<T, I>::get(bridge_id) {
let mut dynamic_fees = sp_std::vec::Vec::with_capacity(fees.len());
for fee in fees.into_inner() {
dynamic_fees
.push(Pallet::<T, I>::apply_dynamic_fee_factor(&bridge_state, fee));
let mut dynamic_fees = fees.into_inner();
for fee in dynamic_fees.iter_mut() {
Pallet::<T, I>::apply_dynamic_fee_factor(&bridge_state, fee);
}
fees = Assets::from(dynamic_fees);
}
Expand Down
11 changes: 3 additions & 8 deletions bridges/modules/xcm-bridge-router/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,9 @@ pub mod pallet {
/// factor specified in the `bridge_state`. If the asset is fungible, the
/// `delivery_fee_factor` is applied to the asset’s amount, potentially altering its
/// value.
pub(crate) fn apply_dynamic_fee_factor(bridge_state: &BridgeState, asset: Asset) -> Asset {
match asset.fun {
Fungible(amount) => {
let adjusted_amount =
bridge_state.delivery_fee_factor.saturating_mul_int(amount);
Asset { fun: Fungible(adjusted_amount), ..asset }
},
_ => asset,
pub(crate) fn apply_dynamic_fee_factor(bridge_state: &BridgeState, asset: &mut Asset) {
if let Fungible(amount) = &mut asset.fun {
*amount = bridge_state.delivery_fee_factor.saturating_mul_int(*amount);
}
}

Expand Down
Loading