Skip to content

Actually use RP offset in YAP parachain #8745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skunert merged 5 commits into from
Jun 5, 2025
Merged

Actually use RP offset in YAP parachain #8745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbd4968
Actually use RP offset in yap
skunert Jun 4, 2025
80d7fe8
Update from github-actions[bot] running command 'prdoc --audience run…
github-actions[bot] Jun 4, 2025
6312150
Update pr_8745.prdoc
skunert Jun 4, 2025
f17978a
Adjust unincluded segment to be correct
skunert Jun 4, 2025
bc932b9
Merge branch 'master' into skunert/fix-yap
skunert Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cumulus/parachains/runtimes/testing/yet-another-parachain/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const MAXIMUM_BLOCK_WEIGHT: Weight = Weight::from_parts(

/// Maximum number of blocks simultaneously accepted by the Runtime, not yet included
/// into the relay chain.
const UNINCLUDED_SEGMENT_CAPACITY: u32 = 7;
const UNINCLUDED_SEGMENT_CAPACITY: u32 = 10;

/// Build with an offset of 1 behind the relay chain.
const RELAY_PARENT_OFFSET: u32 = 1;
Expand Down Expand Up @@ -308,7 +308,7 @@ impl cumulus_pallet_parachain_system::Config for Runtime {
type CheckAssociatedRelayNumber = RelayNumberMonotonicallyIncreases;
type ConsensusHook = ConsensusHook;
type SelectCore = cumulus_pallet_parachain_system::DefaultCoreSelector<Runtime>;
type RelayParentOffset = ConstU32<0>;
type RelayParentOffset = ConstU32<RELAY_PARENT_OFFSET>;
}

impl pallet_message_queue::Config for Runtime {
Expand Down
7 changes: 7 additions & 0 deletions prdoc/pr_8745.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
title: Use correct relay parent offset in YAP parachain
doc:
- audience: Runtime Dev
description: 'The relay parent offset in the yap parachain is now properly set to `RELAY_PARENT_OFFSET`.'
crates:
- name: yet-another-parachain-runtime
bump: patch
Loading