bound trusted local cache to shared limits sizes#8688
Merged
Conversation
Signed-off-by: Alexandru Gheorghe <[email protected]>
AndreiEres
approved these changes
May 28, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: Alexandru Gheorghe <[email protected]>
bkchr
approved these changes
May 28, 2025
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
pgherveou
pushed a commit
that referenced
this pull request
Jun 11, 2025
This #7556 (comment) made me think that we can have some miss-uses of the trusted cache, so it needs some reasonable bounds for the size. Since there is no point in letting it grow past the shared cache limits, because the items will be discarded anyways when we propagate them back to the share cache so I decided to bound it to those limits. --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
This #7556 (comment) made me think that we can have some miss-uses of the trusted cache, so it needs some reasonable bounds for the size. Since there is no point in letting it grow past the shared cache limits, because the items will be discarded anyways when we propagate them back to the share cache so I decided to bound it to those limits. --------- Signed-off-by: Alexandru Gheorghe <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This #7556 (comment) made me think that we can have some miss-uses of the trusted cache, so it needs some reasonable bounds for the size.
Since there is no point in letting it grow past the shared cache limits, because the items will be discarded anyways when we propagate them back to the share cache so I decided to bound it to those limits.