Skip to content

[stable2409] Backport #7785#8626

Merged
EgorPopelyaev merged 2 commits intostable2409from
backport-7785-to-stable2409
May 27, 2025
Merged

[stable2409] Backport #7785#8626
EgorPopelyaev merged 2 commits intostable2409from
backport-7785-to-stable2409

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #7785 into stable2409 from ggwpez.

See the documentation on how to use this bot.

Changes:
- Add runtime integrity test for scheduler pallet to ensure that lookups
use sensible weights
- Check all passed storage names in the omni bencher to be known by
FRAME metadata
- Trim storage names in omni bencher to fix V1 bench syntax bug
- Fix V1 bench syntax storage name sanitization for specific Rust
versions

I re-ran the benchmarks with the omni-bencher modifications and it did
not change the [proof
size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29).
I reverted [the
commit](bb19d78)
afterwards to reduce the noise for reviewers.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 058b4f5)
@paritytech-release-backport-bot paritytech-release-backport-bot bot requested a review from a team as a code owner May 23, 2025 13:23
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 23, 2025
@github-actions github-actions bot requested a review from ggwpez May 23, 2025 13:23
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev EgorPopelyaev merged commit 492786d into stable2409 May 27, 2025
156 of 186 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7785-to-stable2409 branch May 27, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants