Skip to content

Bridges: Fix - Improve try-state for pallet-xcm-bridge#8612

Merged
bkontur merged 1 commit intoparitytech:bko-bridges-congestionfrom
rosarp:rs-bridges-congestion-improve-try-state-for-xcm-bridge
May 22, 2025
Merged

Bridges: Fix - Improve try-state for pallet-xcm-bridge#8612
bkontur merged 1 commit intoparitytech:bko-bridges-congestionfrom
rosarp:rs-bridges-congestion-improve-try-state-for-xcm-bridge

Conversation

@rosarp
Copy link
Copy Markdown
Member

@rosarp rosarp commented May 22, 2025

Fixing #8215 based on #8185: Improve try-state for pallet-xcm-bridge

It removes try_as and uses try_into implementation instead.

After adding test case where VersionedLocation* to have (XCM_VERSION - 1) is , the test case fails.

after-adding-test-before-fix

After adding the fix, by removing try_as and replacing with try_into, test case passed:
after-adding-fix

@rosarp rosarp added R0-no-crate-publish-required The change does not require any crates to be re-published. T15-bridges This PR/Issue is related to bridges. labels May 22, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 22, 2025 10:24
@rosarp rosarp requested a review from bkontur May 22, 2025 10:24
Copy link
Copy Markdown
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you

@bkontur bkontur merged commit df5c3ca into paritytech:bko-bridges-congestion May 22, 2025
155 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T15-bridges This PR/Issue is related to bridges.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants