Skip to content

[stable2412] Backport #7691#8573

Merged
EgorPopelyaev merged 13 commits intostable2412from
backport-7691-to-stable2412
May 21, 2025
Merged

[stable2412] Backport #7691#8573
EgorPopelyaev merged 13 commits intostable2412from
backport-7691-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #7691 into stable2412 from raymondkfcheung.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7691-to-stable2412
git worktree add --checkout .worktree/backport-7691-to-stable2412 backport-7691-to-stable2412
cd .worktree/backport-7691-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 803b3463d512327aee6ab0ca13ac368a2256275a
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label May 20, 2025
@github-actions github-actions bot requested a review from raymondkfcheung May 20, 2025 09:47
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@raymondkfcheung raymondkfcheung added the T6-XCM This PR/Issue is related to XCM. label May 20, 2025
@raymondkfcheung raymondkfcheung moved this to In Progress in Bridges + XCM May 20, 2025
@EgorPopelyaev
Copy link
Copy Markdown
Contributor

@raymondkfcheung could you please double check failing test here: https://github.com/paritytech/polkadot-sdk/actions/runs/15139471927/job/42559530391?pr=8573#step:4:38

@raymondkfcheung raymondkfcheung marked this pull request as ready for review May 21, 2025 15:40
@raymondkfcheung raymondkfcheung requested a review from a team as a code owner May 21, 2025 15:40
@raymondkfcheung raymondkfcheung moved this from In Progress to In-Review in Bridges + XCM May 21, 2025
@raymondkfcheung
Copy link
Copy Markdown
Contributor

Please note that EventEmitter (from #7234) was not backported to stable2412, so some related Sent event code has been removed.

@EgorPopelyaev EgorPopelyaev merged commit 2b24585 into stable2412 May 21, 2025
233 of 330 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7691-to-stable2412 branch May 21, 2025 17:14
@github-project-automation github-project-automation bot moved this from In-Review to Done in Bridges + XCM May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch. T6-XCM This PR/Issue is related to XCM.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants