Bko on kiz vmp message size check#8458
Merged
kianenigma merged 4 commits intokiz-vmp-message-size-checkfrom May 7, 2025
Merged
Bko on kiz vmp message size check#8458kianenigma merged 4 commits intokiz-vmp-message-size-checkfrom
kianenigma merged 4 commits intokiz-vmp-message-size-checkfrom
Conversation
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Contributor
Author
|
/cmd fmt |
kianenigma
reviewed
May 7, 2025
| /// Pre-check the given UMP message. | ||
| fn can_send_upward_message(message: &UpwardMessage) -> Result<(), MessageSendError>; | ||
|
|
||
| /// Ensure `[Self::send_upward_message]` is successful when called in benchmarks/tests. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Ensure `[Self::send_upward_message]` is successful when called in benchmarks/tests. | |
| /// Ensure [`Self::send_upward_message`] is successful when called in benchmarks/tests. |
kianenigma
approved these changes
May 7, 2025
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Nice, thanks for the branch! I will merge this and do the final touches in the base PR 🚀
kianenigma
merged commit dfe5fe5
into
kiz-vmp-message-size-check
238 of 251 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.