Skip to content

[stable2412] Backport #6540#8355

Merged
EgorPopelyaev merged 7 commits intostable2412from
backport-6540-to-stable2412
Apr 30, 2025
Merged

[stable2412] Backport #6540#8355
EgorPopelyaev merged 7 commits intostable2412from
backport-6540-to-stable2412

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

Backport #6540 into stable2412 from Ank4n.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6540-to-stable2412
git worktree add --checkout .worktree/backport-6540-to-stable2412 backport-6540-to-stable2412
cd .worktree/backport-6540-to-stable2412
git reset --hard HEAD^
git cherry-pick -x bf20a9ee18f7215210bbbabf79e955c8c35b3360
git push --force-with-lease

@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

/// No slash pending that can be applied to the member.
NothingToSlash,
/// The slash amount is too low to be applied.
SlashTooLow,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, but we have already backported this to 2407 and 2409, so probably better keep it that way.

@Ank4n Ank4n marked this pull request as ready for review April 28, 2025 05:24
@EgorPopelyaev
Copy link
Copy Markdown
Contributor

@Ank4n @bkontur this pr has a major bump

@Ank4n
Copy link
Copy Markdown
Contributor

Ank4n commented Apr 28, 2025

@Ank4n @bkontur this pr has a major bump

Re: #8355 (comment)

I could make this non-breaking (by reusing an existing error), but given that the same breaking change has already been applied on the backport to stable2409, I think it would be pointless.

@EgorPopelyaev
Copy link
Copy Markdown
Contributor

I see that in those backports the changes were backported as patch, was it done by mistake?

@EgorPopelyaev
Copy link
Copy Markdown
Contributor

Also, I think it wouldn't be pointless, as we won't break one more release, which is in use at the moment

- name: pallet-nomination-pools-runtime-api
bump: patch
- name: pallet-nomination-pools
bump: major
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major bumps in backports are not permissible anymore. They messed up 2503 and we dont want to mess up any more releases because of them...
There is some rational explained here https://forum.parity.io/t/stable-releases/2142/48

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez @EgorPopelyaev
The breaking change here is the introduction of a new error. I can rework this PR to avoid adding a new error and make it non-breaking if needed.

However, the same new error has already been introduced in the backport to stable2409, so not including it here would technically be a breaking change relative to that.

The logic change itself is quite small (under 10 LOC), along with some tests and updated rustdocs.
This patch addresses a potential low- to mid-severity security issue, preventing a feeless transactions from being triggered with very small values.

P.S.: I am happy to comply based on your preference, just trying to understand the best path forward.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for changing it to not break this release

@EgorPopelyaev EgorPopelyaev merged commit 51e2940 into stable2412 Apr 30, 2025
175 of 196 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6540-to-stable2412 branch April 30, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants