[stable2412] Backport #6540#8355
Conversation
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6540-to-stable2412
git worktree add --checkout .worktree/backport-6540-to-stable2412 backport-6540-to-stable2412
cd .worktree/backport-6540-to-stable2412
git reset --hard HEAD^
git cherry-pick -x bf20a9ee18f7215210bbbabf79e955c8c35b3360
git push --force-with-lease |
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
| /// No slash pending that can be applied to the member. | ||
| NothingToSlash, | ||
| /// The slash amount is too low to be applied. | ||
| SlashTooLow, |
|
Re: #8355 (comment) I could make this non-breaking (by reusing an existing error), but given that the same breaking change has already been applied on the backport to stable2409, I think it would be pointless. |
|
I see that in those backports the changes were backported as patch, was it done by mistake? |
|
Also, I think it wouldn't be pointless, as we won't break one more release, which is in use at the moment |
prdoc/pr_6540.prdoc
Outdated
| - name: pallet-nomination-pools-runtime-api | ||
| bump: patch | ||
| - name: pallet-nomination-pools | ||
| bump: major |
There was a problem hiding this comment.
Major bumps in backports are not permissible anymore. They messed up 2503 and we dont want to mess up any more releases because of them...
There is some rational explained here https://forum.parity.io/t/stable-releases/2142/48
There was a problem hiding this comment.
@ggwpez @EgorPopelyaev
The breaking change here is the introduction of a new error. I can rework this PR to avoid adding a new error and make it non-breaking if needed.
However, the same new error has already been introduced in the backport to stable2409, so not including it here would technically be a breaking change relative to that.
The logic change itself is quite small (under 10 LOC), along with some tests and updated rustdocs.
This patch addresses a potential low- to mid-severity security issue, preventing a feeless transactions from being triggered with very small values.
P.S.: I am happy to comply based on your preference, just trying to understand the best path forward.
There was a problem hiding this comment.
I would go for changing it to not break this release
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Backport #6540 into
stable2412from Ank4n.See the documentation on how to use this bot.