Skip to content

Check umbrella version #8250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iulianbarbu merged 13 commits into from
Apr 25, 2025
+19 −1
Merged

Check umbrella version #8250

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
df20d17
Add a means to fetch the umbrella version and set it dynamically depe…
Wolfenheimm Apr 15, 2025
60099b1
Add version detection logic and tests to check-umbrella job
Wolfenheimm Apr 15, 2025
f1ea326
Add more robust testing output, Add extra testing scenarios
Wolfenheimm Apr 15, 2025
b74b599
Fix the checks-quick workflow to be minimalistic in using the cargo m…
Wolfenheimm Apr 16, 2025
36f2e75
Add prdoc
Wolfenheimm Apr 16, 2025
194577b
Merge branch 'master' into wolfenheimm/check-umbrella-version
Wolfenheimm Apr 16, 2025
77e82fe
Fix issue where multiple versions are pulled from metadata
Wolfenheimm Apr 17, 2025
e498dd4
Merge branch 'wolfenheimm/check-umbrella-version' of https://github.c…
Wolfenheimm Apr 17, 2025
f6753a9
Remove prdoc (unnecessary for CI changes)
Wolfenheimm Apr 18, 2025
a38e1e9
Merge branch 'master' into wolfenheimm/check-umbrella-version
Wolfenheimm Apr 18, 2025
153d850
Merge branch 'master' into wolfenheimm/check-umbrella-version
iulianbarbu Apr 23, 2025
458bdd2
Merge branch 'master' into wolfenheimm/check-umbrella-version
iulianbarbu Apr 24, 2025
f40f7dc
Merge branch 'master' into wolfenheimm/check-umbrella-version
iulianbarbu Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/workflows/checks-quick.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,25 @@ jobs:
run: |
# Fixes "detected dubious ownership" error in the ci
git config --global --add safe.directory '*'
python3 scripts/generate-umbrella.py --sdk . --version 0.1.0

# Ensure jq is installed
if ! command -v jq &> /dev/null; then
echo "Installing jq..."
apt-get update && apt-get install -y jq
fi

# Extract the umbrella crate version dynamically from cargo metadata
UMBRELLA_VERSION=$(cargo metadata --format-version=1 | jq -r '.packages[] | select(.manifest_path | endswith("umbrella/Cargo.toml")) | .version')

if [ -z "$UMBRELLA_VERSION" ]; then
echo "Warning: Could not determine umbrella version from cargo metadata, using fallback version 0.1.0"
UMBRELLA_VERSION="0.1.0"
fi

echo "Using umbrella crate version: $UMBRELLA_VERSION"

python3 scripts/generate-umbrella.py --sdk . --version "$UMBRELLA_VERSION"

cargo +nightly fmt -p polkadot-sdk

if [ -n "$(git status --porcelain)" ]; then
Expand Down
Loading