Skip to content

silent nomination-pools try-state check #8246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ordian merged 1 commit into from
Apr 15, 2025
Merged

silent nomination-pools try-state check #8246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions substrate/frame/nomination-pools/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3989,15 +3989,17 @@ impl<T: Config> Pallet<T> {
// migrated, the total balance would be none.
.unwrap_or(T::Currency::total_balance(&pool_account));

assert!(
total_balance >= bonded_balance + sum_unbonding_balance,
"faulty pool: {:?} / {:?}, total_balance {:?} >= bonded_balance {:?} + sum_unbonding_balance {:?}",
pool_id,
_pool,
total_balance,
bonded_balance,
sum_unbonding_balance
);
if total_balance < bonded_balance + sum_unbonding_balance {
log!(
warn,
"possibly faulty pool: {:?} / {:?}, total_balance {:?} >= bonded_balance {:?} + sum_unbonding_balance {:?}",
pool_id,
_pool,
total_balance,
bonded_balance,
sum_unbonding_balance
)
};
}

// Warn if any pool has incorrect ED frozen. We don't want to fail hard as this could be a
Expand Down
Loading