Enable statement store in polkadot-omni-node and polkadot-parachain

cumulus/polkadot-omni-node/lib/Cargo.toml

@@ -56,6 +56,7 @@ sc-rpc = { workspace = true, default-features = true }
 sc-runtime-utilities = { workspace = true, default-features = true }
 sc-service = { workspace = true, default-features = false }
 sc-sysinfo = { workspace = true, default-features = true }
+sc-statement-store = { workspace = true, default-features = true }
 sc-telemetry = { workspace = true, default-features = true }
 sc-tracing = { workspace = true, default-features = true }
 sc-transaction-pool = { workspace = true, default-features = true }
@@ -71,6 +72,7 @@ sp-keystore = { workspace = true, default-features = true }
 sp-offchain = { workspace = true, default-features = true }
 sp-runtime = { workspace = true }
 sp-session = { workspace = true, default-features = true }
+sp-statement-store = { workspace = true, default-features = true }
 sp-storage = { workspace = true, default-features = true }
 sp-timestamp = { workspace = true, default-features = true }
 sp-transaction-pool = { workspace = true, default-features = true }

cumulus/polkadot-omni-node/lib/src/cli.rs

@@ -166,6 +166,14 @@ pub struct Cli<Config: CliConfig> {
 	#[arg(long)]
 	pub dev_block_time: Option<u64>,
 
+	/// Disable the statement store.
+	///
+	/// The statement store is an off-chain data-store for signed statements accessible via RPC
+	/// and OCW.
+	/// It uses the runtime api to get the allowance associated to an account.
+	#[arg(long)]
+	pub disable_statement_store: bool,
+
 	/// DEPRECATED: This feature has been stabilized, pLease use `--authoring slot-based` instead.
 	///
 	/// Use slot-based collator which can handle elastic scaling.
@@ -231,6 +239,7 @@ impl<Config: CliConfig> Cli<Config> {
 				.then(|| AuthoringPolicy::SlotBased)
 				.unwrap_or(self.authoring),
 			export_pov: self.export_pov_to_path.clone(),
+			disable_statement_store: self.disable_statement_store,
 			max_pov_percentage: self.run.experimental_max_pov_percentage,
 		}
 	}

cumulus/polkadot-omni-node/lib/src/common/mod.rs

@@ -38,6 +38,7 @@ use sp_runtime::{
 	OpaqueExtrinsic,
 };
 use sp_session::SessionKeys;
+use sp_statement_store::runtime_api::ValidateStatement;
 use sp_transaction_pool::runtime_api::TaggedTransactionQueue;
 use std::{fmt::Debug, path::PathBuf, str::FromStr};
 
@@ -70,6 +71,7 @@ pub trait NodeRuntimeApi<Block: BlockT>:
 	+ OffchainWorkerApi<Block>
 	+ CollectCollationInfo<Block>
 	+ GetCoreSelectorApi<Block>
+	+ ValidateStatement<Block>
 	+ Sized
 {
 }
@@ -83,6 +85,7 @@ impl<T, Block: BlockT> NodeRuntimeApi<Block> for T where
 		+ OffchainWorkerApi<Block>
 		+ GetCoreSelectorApi<Block>
 		+ CollectCollationInfo<Block>
+		+ ValidateStatement<Block>
 {
 }
 
@@ -113,6 +116,9 @@ pub struct NodeExtraArgs {
 	/// If set, each `PoV` build by the node will be exported to this folder.
 	pub export_pov: Option<PathBuf>,
 
+	/// Disable the statement store.
+	pub disable_statement_store: bool,
+
 	/// The maximum percentage of the maximum PoV size that the collator can use.
 	/// It will be removed once <https://github.com/paritytech/polkadot-sdk/issues/6020> is fixed.
 	pub max_pov_percentage: Option<u32>,

cumulus/polkadot-omni-node/lib/src/common/rpc.rs

@@ -23,7 +23,10 @@ use crate::common::{
 	ConstructNodeRuntimeApi,
 };
 use pallet_transaction_payment_rpc::{TransactionPayment, TransactionPaymentApiServer};
-use sc_rpc::dev::{Dev, DevApiServer};
+use sc_rpc::{
+	dev::{Dev, DevApiServer},
+	statement::{StatementApiServer, StatementStore},
+};
 use sp_runtime::traits::Block as BlockT;
 use std::{marker::PhantomData, sync::Arc};
 use substrate_frame_rpc_system::{System, SystemApiServer};
@@ -32,11 +35,12 @@ use substrate_state_trie_migration_rpc::{StateMigration, StateMigrationApiServer
 /// A type representing all RPC extensions.
 pub type RpcExtension = jsonrpsee::RpcModule<()>;
 
-pub(crate) trait BuildRpcExtensions<Client, Backend, Pool> {
+pub(crate) trait BuildRpcExtensions<Client, Backend, Pool, StatementStore> {
 	fn build_rpc_extensions(
 		client: Arc<Client>,
 		backend: Arc<Backend>,
 		pool: Arc<Pool>,
+		statement_store: Option<Arc<StatementStore>>,
 	) -> sc_service::error::Result<RpcExtension>;
 }
 
@@ -47,6 +51,7 @@ impl<Block: BlockT, RuntimeApi>
 		ParachainClient<Block, RuntimeApi>,
 		ParachainBackend<Block>,
 		sc_transaction_pool::TransactionPoolHandle<Block, ParachainClient<Block, RuntimeApi>>,
+		sc_statement_store::Store,
 	> for BuildParachainRpcExtensions<Block, RuntimeApi>
 where
 	RuntimeApi:
@@ -60,13 +65,17 @@ where
 		pool: Arc<
 			sc_transaction_pool::TransactionPoolHandle<Block, ParachainClient<Block, RuntimeApi>>,
 		>,
+		statement_store: Option<Arc<sc_statement_store::Store>>,
 	) -> sc_service::error::Result<RpcExtension> {
 		let build = || -> Result<RpcExtension, Box<dyn std::error::Error + Send + Sync>> {
 			let mut module = RpcExtension::new(());
 
 			module.merge(System::new(client.clone(), pool).into_rpc())?;
 			module.merge(TransactionPayment::new(client.clone()).into_rpc())?;
 			module.merge(StateMigration::new(client.clone(), backend).into_rpc())?;
+			if let Some(statement_store) = statement_store {
+				module.merge(StatementStore::new(statement_store).into_rpc())?;
+			}
 			module.merge(Dev::new(client).into_rpc())?;
 
 			Ok(module)

cumulus/polkadot-omni-node/lib/src/common/spec.rs

@@ -40,6 +40,7 @@ use sc_consensus::DefaultImportQueue;
 use sc_executor::{HeapAllocStrategy, DEFAULT_HEAP_ALLOC_STRATEGY};
 use sc_network::{config::FullNetworkConfiguration, NetworkBackend, NetworkBlock};
 use sc_service::{Configuration, ImportQueue, PartialComponents, TaskManager};
+use sc_statement_store::Store;
 use sc_sysinfo::HwBench;
 use sc_telemetry::{TelemetryHandle, TelemetryWorker};
 use sc_tracing::tracing::Instrument;
@@ -239,6 +240,7 @@ pub(crate) trait NodeSpec: BaseNodeSpec {
 		ParachainClient<Self::Block, Self::RuntimeApi>,
 		ParachainBackend<Self::Block>,
 		TransactionPoolHandle<Self::Block, ParachainClient<Self::Block, Self::RuntimeApi>>,
+		Store,
 	>;
 
 	type StartConsensus: StartConsensus<
@@ -284,6 +286,22 @@ pub(crate) trait NodeSpec: BaseNodeSpec {
 			.await
 			.map_err(|e| sc_service::Error::Application(Box::new(e) as Box<_>))?;
 
+			let statement_store = if !node_extra_args.disable_statement_store {
+				let statement_store = sc_statement_store::Store::new_shared(
+					&parachain_config.data_path,
+					Default::default(),
+					client.clone(),
+					params.keystore_container.local_keystore(),
+					parachain_config.prometheus_registry(),
+					&task_manager.spawn_handle(),
+				)
+				.map_err(|e| sc_service::Error::Application(Box::new(e) as Box<_>))?;
+
+				Some(statement_store)
+			} else {
+				None
+			};
+
 			let validator = parachain_config.role.is_authority();
 			let prometheus_registry = parachain_config.prometheus_registry().cloned();
 			let transaction_pool = params.transaction_pool.clone();
@@ -332,12 +350,14 @@ pub(crate) trait NodeSpec: BaseNodeSpec {
 				let client = client.clone();
 				let transaction_pool = transaction_pool.clone();
 				let backend_for_rpc = backend.clone();
+				let statement_store = statement_store.clone();
 
 				Box::new(move |_| {
 					Self::BuildRpcExtensions::build_rpc_extensions(
 						client.clone(),
 						backend_for_rpc.clone(),
 						transaction_pool.clone(),
+						statement_store.clone(),
 					)
 				})
 			};

cumulus/polkadot-omni-node/lib/src/fake_runtime_api/utils.rs

@@ -227,6 +227,15 @@ macro_rules! impl_node_runtime_apis {
 					unimplemented!()
 				}
 			}
+
+			impl sp_statement_store::runtime_api::ValidateStatement<$block> for $runtime {
+				fn validate_statement(
+					_source: sp_statement_store::runtime_api::StatementSource,
+					_statement: sp_statement_store::Statement,
+				) -> Result<sp_statement_store::runtime_api::ValidStatement, sp_statement_store::runtime_api::InvalidStatement> {
+					unimplemented!()
+				}
+			}
 		}
 	};
 }

cumulus/polkadot-omni-node/lib/src/nodes/manual_seal.rs

@@ -259,6 +259,7 @@ impl<NodeSpec: NodeSpecT> ManualSealNode<NodeSpec> {
 					client.clone(),
 					backend_for_rpc.clone(),
 					transaction_pool.clone(),
+					None,
 				)?;
 				module
 					.merge(ManualSeal::new(manual_seal_sink.clone()).into_rpc())

prdoc/pr_8076.prdoc

@@ -0,0 +1,14 @@
+title: 'Enable statement store in polkadot-omni-node and polkadot-parachain'
+doc:
+- audience: Node Operator
+  description: |-
+    This PR introduces and enables the statement store and add a new argument `disable_statement_store` in `polkadot-omni-node-lib`.
+    This takes effect in `polkadot-omni-node` and `polkadot-parachain` and any node depending on `polkadot-omni-node-lib`.
+
+    The statement store is an off-chain data-store for signed statements accessible via RPC and OCW.
+    It uses the runtime api to get the allowance associated to an account.
+
+    If the runtime doesn't implement the API `ValidateStatement` then all statement submission will safely fail with the error `Error calling into the runtime`.
+crates:
+- name: polkadot-omni-node-lib
+  bump: major