Skip to content

Snowbridge - Removes unused method from Outbound Queue v2#8022

Closed
claravanstaden wants to merge 1 commit intoparitytech:masterfrom
claravanstaden:removes-unused-method
Closed

Snowbridge - Removes unused method from Outbound Queue v2#8022
claravanstaden wants to merge 1 commit intoparitytech:masterfrom
claravanstaden:removes-unused-method

Conversation

@claravanstaden
Copy link
Copy Markdown
Contributor

Resolves: SNO-1431

@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 25, 2025 10:10
@acatangiu acatangiu added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 25, 2025
@acatangiu acatangiu requested a review from a team March 25, 2025 11:40
@acatangiu acatangiu enabled auto-merge March 25, 2025 11:40
@acatangiu acatangiu added the A4-backport-stable2503 Pull request must be backported to the stable2503 release branch label Mar 25, 2025
@yrong
Copy link
Copy Markdown
Contributor

yrong commented Mar 26, 2025

I don't think we can remove the calculate_local_fee, as the benchmarked functions are internal and not extrinsics, which means the UX can't dry-run to get the cost.

So on the contrary, we may still need to add a runtime API to expose it to the UX.

@claravanstaden
Copy link
Copy Markdown
Contributor Author

Merged into #8020 for easier backporting.

auto-merge was automatically disabled March 26, 2025 09:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2503 Pull request must be backported to the stable2503 release branch R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants