UncheckedExtrinsic: lazily decode the call#7902
Closed
serban300 wants to merge 7 commits intoparitytech:masterfrom
Closed
UncheckedExtrinsic: lazily decode the call#7902serban300 wants to merge 7 commits intoparitytech:masterfrom
UncheckedExtrinsic: lazily decode the call#7902serban300 wants to merge 7 commits intoparitytech:masterfrom
Conversation
serban300
added
the
T17-primitives
serban300
force-pushed
the
unchecked-extrinsic
branch
5 times, most recently
from
368c27a to
4e1cafb
Compare
serban300
changed the title
UncheckedExtrinsic: lazy decoding + set a memory limit when decoding the callUncheckedExtrinsic: lazily decode and limit the call
serban300
force-pushed
the
unchecked-extrinsic
branch
2 times, most recently
from
520f415 to
099a094
Compare
bkchr
reviewed
Mar 13, 2025
serban300
force-pushed
the
unchecked-extrinsic
branch
from
099a094 to
dbee656
Compare
This was referenced Mar 14, 2025
serban300
added
the
I9-optimisation
serban300
force-pushed
the
unchecked-extrinsic
branch
2 times, most recently
from
506a5bf to
51b5cb4
Compare
serban300
force-pushed
the
unchecked-extrinsic
branch
from
51b5cb4 to
1b70876
Compare
serban300
force-pushed
the
unchecked-extrinsic
branch
4 times, most recently
from
bb5a405 to
7a77636
Compare
serban300
changed the title
UncheckedExtrinsic: lazily decode and limit the callUncheckedExtrinsic: lazily decode and limit the call
Contributor
Author
serban300
force-pushed
the
unchecked-extrinsic
branch
2 times, most recently
from
5930635 to
000d75c
Compare
serban300
force-pushed
the
unchecked-extrinsic
branch
4 times, most recently
from
c729ad0 to
c8053ff
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
Stumbled upon this while working on other issue (#7902). I thought I might need to change the `CheckInherentsResult` and this deduplication would have made everything easier. Probably changing `CheckInherentsResult` won't be needed in the end, but even so it would be nice to reduce the duplication. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
serban300
force-pushed
the
unchecked-extrinsic
branch
6 times, most recently
from
c9f3ede to
5fe90bf
Compare
Define: - TransactionPayment::query_info_from_runtime_api() - TransactionPayment::query_fee_details_from_runtime_api()
Define: - InherentDataExt::check_extrinsics_from_runtime_api()
serban300
force-pushed
the
unchecked-extrinsic
branch
from
5fe90bf to
ce076ac
Compare
bkchr
reviewed
Aug 1, 2025
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
When looking at this pr again, we only need the lazy decoding in two situations:
execute_blockvalidate_block
Instead of concentrating the "fallout" on these two situations, right now we just change everything. However, I don't see the need given that we only need this in two situations. Or do I miss something?
Something like is_inherent and other calls should not be changed at all, because when we reach them the extrinsic should be already decoded and available.
Contributor
Author
Thanks for the suggestion ! Opened a new PR that implements this approach: #9480 Closing this PR in favor of the new one |
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Stumbled upon this while working on other issue (#7902). I thought I might need to change the `CheckInherentsResult` and this deduplication would have made everything easier. Probably changing `CheckInherentsResult` won't be needed in the end, but even so it would be nice to reduce the duplication. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
Related to #4255 Addresses #7902 (review) This PR enables us to lazily decode the block extrinsics when needed. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4255
This PR changes some core logic in order to lazily decode the
RuntimeCallinside anUncheckedExtrinsicThis is a significant rework of #4296. The main problem with #4296 was that it was always decoding a call at least twice. This PR comes with a different approach, that avoids the need to decode twice.