Skip to content

Revert "[Assets] Implement pallet-assets-holder (#4530)"#7615

Closed
gui1117 wants to merge 1 commit intomasterfrom
gui-revert-assets-holder-4530
Closed

Revert "[Assets] Implement pallet-assets-holder (#4530)"#7615
gui1117 wants to merge 1 commit intomasterfrom
gui-revert-assets-holder-4530

Conversation

@gui1117
Copy link
Copy Markdown
Contributor

@gui1117 gui1117 commented Feb 19, 2025

This reverts commit 83db047.

Sorry, I pushed the merge button before the audit of the PR, this reverts the commit.

For backport for 2503 see: #7616

@gui1117 gui1117 requested review from a team as code owners February 19, 2025 00:19
@gui1117 gui1117 added R0-no-crate-publish-required The change does not require any crates to be re-published. T2-pallets This PR/Issue is related to a particular pallet. labels Feb 19, 2025
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Feb 19, 2025

I don't think we need to revert this. This is an extra pallet and if it is not used, there is no security issue with it.

@bkchr bkchr closed this Feb 19, 2025
@bkchr bkchr deleted the gui-revert-assets-holder-4530 branch February 19, 2025 10:40
@gui1117
Copy link
Copy Markdown
Contributor Author

gui1117 commented Feb 19, 2025

I don't think we need to revert this. This is an extra pallet and if it is not used, there is no security issue with it.

It adds change in pallet-assets: substrate/frame/assets/src/functions.rs
The calculation of freezing is changed, with this PR it is now respecting the documentation in fungibles: ED is included in the frozen amount: so if Alice have 10 DOT and ED is 1 and frozen is 4 then before the PR spendable amount is 5, after the PR spendable amount is 4.

cc @muharem

@gui1117
Copy link
Copy Markdown
Contributor Author

gui1117 commented Feb 19, 2025

Maybe we can have an audit only for the change in substrate/frame/assets/src/functions.rs and we can expect it before 2503 release.

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Feb 19, 2025

Maybe we can have an audit only for the change in substrate/frame/assets/src/functions.rs and we can expect it before 2503 release.

As said in the backport pr, let's revert it in the 2503 release.

EgorPopelyaev pushed a commit that referenced this pull request Feb 20, 2025
… 2503 (#7616)

This reverts commit 83db047.

Sorry, I pushed the merge button before the audit of the PR, this
reverts the commit for `stable2503` branch

For master branch seee:
#7615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants