-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Introduce CreateBare, deprecated CreateInherent #7597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b603f2c
28e0ab3
e3de76b
2068d7e
1565a6a
84a9e90
2e14572
be4e019
1a51d59
41e0a39
2b61876
d804858
1aa50c0
9274b16
1512357
412b80d
ee3836f
a1afad7
3f7dbe1
d9da435
7794fbd
f98da0f
59b532a
e29ec07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -489,8 +489,14 @@ pub trait CreateSignedTransaction<LocalCall>: | |||||||
| } | ||||||||
|
|
||||||||
| /// Interface for creating an inherent. | ||||||||
| /// | ||||||||
| /// It can also be used to create an unsigned transaction as they are both the same extrinsic | ||||||||
| /// variant: `Bare`. Unsigned transaction are deprecated in favor of general transaction. | ||||||||
| pub trait CreateInherent<LocalCall>: CreateTransactionBase<LocalCall> { | ||||||||
|
||||||||
| pub trait CreateInherent<LocalCall>: CreateTransactionBase<LocalCall> { | |
| #[deprecated(note = "Please use `CreateBare` instead")] | |
| pub trait CreateInherent<LocalCall>: CreateTransactionBase<LocalCall> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I will also change usage of CreateInherent to CreateBare in pokadot-sdk, in pallets (and runtime but this is less important).
EDIT: otherwise runtime implementing only CreateBare won't be able to use like election-solution pallet which uses CreateInherent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: otherwise runtime implementing only
CreateBarewon't be able to use likeelection-solutionpallet which usesCreateInherent.
I mean you can still implement CreateInherent, just with a allow(deprecated).
Uh oh!
There was an error while loading. Please reload this page.