-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Paras authorize_code_hash + apply_authorized_code feature
#7592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
90fa441
Added `authorize_force_set_current_code_hash` feature
bkontur 693c277
Add `force_set_current_code` test
bkontur 1a9dba4
Update from bkontur running command 'fmt'
github-actions[bot] 8dc2779
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur e14f331
Fix Rococo/Westend
bkontur a3d1f3c
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur 9bb38f3
Merge remote-tracking branch 'origin/bko-paras-authorize-set-current-…
bkontur 9eea06f
Update from bkontur running command 'prdoc --audience runtime_dev --b…
github-actions[bot] caff716
Update prdoc/pr_7592.prdoc
bkontur 4d746d2
Update from bkontur running command 'bench --pallet polkadot_runtime_…
github-actions[bot] bde0c00
Apply suggestions from code review
bkontur 6062032
Update polkadot/runtime/parachains/src/paras/mod.rs
bkontur 3243e63
Dedicated enum variant `NotAuthorizedCode`
bkontur 1aeb6b3
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 77463f4
Update from bkontur running command 'fmt'
github-actions[bot] a1225cb
Update prdoc/pr_7592.prdoc
bkontur a699970
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur ad37325
Align error codes with other pallets
bkontur d0c6e45
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 65ec72b
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur eaf9a78
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur f10b0a8
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur 841f4e4
Refactor finished
bkontur 560c6bb
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur 83abc82
Update from bkontur running command 'fmt'
github-actions[bot] 1eb117e
Update from bkontur running command 'bench --pallet polkadot_runtime_…
github-actions[bot] 8b1a483
Update from bkontur running command 'prdoc --audience runtime_dev --b…
github-actions[bot] 795d59a
Apply suggestions from code review
bkontur 5bde2fd
Apply suggestions from code review
bkontur ad907ab
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 7c386ec
Add `validate_unsigned` validation for `apply_authorized_code`
bkontur 033f908
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur f6981d0
Update from bkontur running command 'fmt'
github-actions[bot] ab3a823
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur d5800fc
Revert
bkontur 15552cc
Revert and simplify
bkontur 6e0cccb
Update from bkontur running command 'prdoc --audience runtime_dev --b…
github-actions[bot] 3cdb61e
Update from bkontur running command 'fmt'
github-actions[bot] 3157c46
Update prdoc/pr_7592.prdoc
bkontur 9bd8c32
Update prdoc/pr_7592.prdoc
bkontur 4ef9b78
ehm
bkontur b4fdadc
Update from bkontur running command 'bench --pallet polkadot_runtime_…
github-actions[bot] 1a94e0d
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur 9bb5f67
Nit
bkontur d6eb3c2
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur e37f698
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 1a8e1fd
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 2f26d71
Update polkadot/runtime/parachains/src/paras/mod.rs
bkontur 6b46716
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur cb1dde3
Use `struct AuthorizedCodeHashAndExpiry` instead of a tuple
bkontur 1e52cf9
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur 1cb919e
Simplify `validate_code_is_authorized`
bkontur 407a430
Add `AuthorizeCurrentCodeOrigin` and allow it for root or Collectives…
bkontur 90a8d44
Update from github-actions[bot] running command 'fmt'
github-actions[bot] f500e19
Fix benchmarks compilation
bkontur f34663f
Update polkadot/runtime/parachains/src/paras/benchmarking.rs
bkontur ad5a78e
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur a8c4624
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur f9a2de9
Fix test compilation
bkontur 9fbb144
Update prdoc/pr_7592.prdoc
bkontur 2409b1c
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 70e7acf
Update polkadot/runtime/parachains/src/paras/mod.rs
bkontur a7be028
Update prdoc/pr_7592.prdoc
bkontur d770e0a
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur a4ccb10
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 56bd15c
Update from github-actions[bot] running command 'fmt'
github-actions[bot] 651d7b4
Nit
bkontur a067b68
Merge remote-tracking branch 'origin/master' into bko-paras-authorize…
bkontur 8b81724
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur a3e9f5f
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur f07b826
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 6075ad7
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 822a1ec
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 8036264
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur abdde6c
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur b110076
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur 0cb5c59
Merge branch 'master' into bko-paras-authorize-set-current-code
bkontur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems strange to also use the code size as the expiry time. If we expect this to affect the benchmark, it should be its own parameter, if not should we not just set it to something constant?