-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Follow up for: Use the umbrella crate for the parachain template #5993 #7464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
458f1d0
removing unused imports
a7eafd4
cargo lock commit
1b4dadf
removing sc-tracing from parachain node
31c7872
restoring dependencies
5a107ef
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 60a91c2
adding sc-tracing in umbrella
64a49ad
importing sc-tracing
397a818
using sc-tracing from polkadot sdk
a889bbc
adding sc-tracing-proc-macro
9ae57ca
updating cargo toml for umbrella
b2c016a
Update umbrella/Cargo.toml
seemantaggarwal e15c49d
removing breaking umbrella updates
ec70c2e
trial and error
8a09b44
creating a new feature for umbrella
38c3dcc
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal a62bced
cargo fmt
afcd41f
adding additional crate_name resolution for sc-tracing
db8ca90
fast forwarding Cargo.lock
e20a4f1
adding prdoc
718604e
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal ab2822e
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 8310ca2
taplo and fmt
3ef39b8
cargo.lock patch
0ae2a6c
cargo fmt
02d57d5
taplo format
1c69a34
simplifying crate_name code
f0f65c8
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 3f36de3
step towards replicating codec into sc-tracing
ad6e74a
effort for including sc-tracing in polkadot-sdk
4ad0f0a
changing logic from startswith to fix value for polkadot-sdk resolution
2f95de5
reverting last commit
c7a07b9
cargo fmt
ac9c846
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 5166954
making further changes
e2f570d
further effort, no success
52e0448
implementing suggested changes
13142f1
cargo and taplo
41f6258
resolving cargo.lock conflicts
7cf4e92
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 41a860e
cargo fmt
60f3a6a
adding sc_tracing::loggin in sc-tracing feature
1ed9c36
removing unused imports
c93ad26
fixing umbrella crate changes
5391802
reverting changes from Cargo.toml
00c3bfa
explicit import for sc_tracing::logging
f0128f5
fixes
serban300 38d5c3c
messy attempt to re‑exports the logging module so that it’s availabl…
545d223
Update from seemantaggarwal running command 'fmt'
github-actions[bot] 3cf488b
adding licenses
8f1997e
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 10b5b92
conflict resolution on Cargo.lock
abf5bf5
fix errors
iulianbarbu 51818d8
addressing comments
98a0fb2
Merge branch 'master' into seemant-parachain-umbrella-crate-mig
seemantaggarwal 47e892d
Update from github-actions[bot] running command 'fmt'
github-actions[bot] 93dd76e
Remove empty line
serban300 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.