omni-node: Adjust manual seal parameters#7451
Merged
Conversation
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
lexnv
approved these changes
Feb 5, 2025
iulianbarbu
approved these changes
Feb 5, 2025
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7451-to-stable2407
git worktree add --checkout .worktree/backport-7451-to-stable2407 backport-7451-to-stable2407
cd .worktree/backport-7451-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease |
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7451-to-stable2409
git worktree add --checkout .worktree/backport-7451-to-stable2409 backport-7451-to-stable2409
cd .worktree/backport-7451-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease |
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7451-to-stable2412
git worktree add --checkout .worktree/backport-7451-to-stable2412 backport-7451-to-stable2412
cd .worktree/backport-7451-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 9c474d5452a855adc843785c71fc842f81eeed56
git push --force-with-lease |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 7, 2025
Backport #7451 into `stable2412` from skunert. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
This PR will make omni-node dev-mode once again compatible with older runtimes. The changes introduced in paritytech#6825 changed constraints that are enforced in the runtime. For normal chains this should work fine, since we have real parameters there, like relay chain slots and parachain slots. For these manual seal parameters we need to respect the constraints, while faking all the parameters. This PR should fix manual seal in omni-node to work with runtime build before and after paritytech#6825 (I tested that). In the future, we should look into improving the parameterization here, possibly by introducing proper aura pre-digests so that the parachain slot moves forward. This will require quite a bit of refactoring on the manual seal node side however. Issue: paritytech#7453 Also, the dev chain spec in parachain template is updated. This makes it work with stable2412-1 and master omni-node. Once the changes here are backported and in a release, all combinations will work again. fixes paritytech#7341 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will make omni-node dev-mode once again compatible with older runtimes.
The changes introduced in #6825 changed constraints that are enforced in the runtime. For normal chains this should work fine, since we have real parameters there, like relay chain slots and parachain slots.
For these manual seal parameters we need to respect the constraints, while faking all the parameters. This PR should fix manual seal in omni-node to work with runtime build before and after #6825 (I tested that).
In the future, we should look into improving the parameterization here, possibly by introducing proper aura pre-digests so that the parachain slot moves forward. This will require quite a bit of refactoring on the manual seal node side however. Issue: #7453
Also, the dev chain spec in parachain template is updated. This makes it work with stable2412-1 and master omni-node. Once the changes here are backported and in a release, all combinations will work again.
fixes #7341