Auto-update of all weights for 2025-01-25-1737769694

[paritytech-cmd-bot-polkadot-sdk]

Auto-update of all weights for 2025-01-25-1737769694

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12960658092
Failed job name: build-runtimes-polkavm

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12960658076
Failed job name: check-try-runtime

[gui1117]

I think the templates are using frame but not all crates have frame as a dependency. So it fails to compile.

Either we add frame as a dependency, to all concerned crates, or we revert the change in the template

[mordamax]

@gui1117 the goal would be that next time it regenerates - it won't fail. if we revert a change in template, https://github.com/paritytech/polkadot-sdk/pull/6789/files#diff-5a2955b61af496005e95ef8d82448fcd76fd957fe4f382b1a757bdfaf0335dd4 then the multisig will be failing next time again?
or pallet_multisig should've used other template based on umbrella crate https://github.com/paritytech/polkadot-sdk/blob/master/.github/scripts/cmd/cmd.py#L227? I wonder may be the dependencies of the multisig_pallet should've fixed instead so it picks up the right template instead of fixing the old templaet

[gui1117]

I see.
Looking again, what I see failing is frame-system, because the dependency frame doesn't exist. But frame-system should better not depend on frame to avoid a cyclic dependency.

And the template substrate/.maintain/frame-weight-template.hbs is using frame.

system should not use frame.

Is there a reason substrate/.maintain/frame-weight-template.hbs is using frame and not frame-support.
EDIT: yes it seems multisig_pallet should be fixed and we shouldn't change the old template

[kianenigma]

The weight generation script should inspect the crate, and make a decision about the template based on:

1. if frame is a dependency
2. if not.

I have not seen the PR, but this should work in practice. @gui1117 does this make sense?

[mordamax]

Here's a PR fixing a template issue #7362
I will re-start generation all pallets once ☝️ merged

[gui1117]

The weight generation script should inspect the crate, and make a decision about the template based on:

1. if `frame` is a dependency

2. if not.

I have not seen the PR, but this should work in practice. @gui1117 does this make sense?

Yes, the template were changed to always use frame in both cases. This should be now fixed. we will see if there is any error remaining.