Update XCM benchmarks delivery to sibling parachains not parent/relay chain#7321
Merged
karolk91 merged 249 commits intoparitytech:masterfrom Jul 31, 2025
Merged
Conversation
EleisonC
changed the title
Contributor
Author
|
Hey @bkontur I am Kindly requesting for your feedback on this. PR |
bkontur
requested changes
Jan 24, 2025
Contributor
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
the point here for AssetHubWestend was to change location Parent to the RandomParaLocation for delivery (but only those Parent which represents destination and not the AssetId)
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
…onfig.rs Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Contributor
Author
Hey @bkontur |
Contributor
Author
|
Hey @bkontur, I have refactored the locations in the asset-hub-rococo. Could you kindly let me know if we are on track? |
…t-hub-westend --pallet pallet_xcm pallet_xcm_benchmarks::generic pallet_xcm_benchmarks::fungible'
Contributor
|
Command "bench --runtime asset-hub-westend --pallet pallet_xcm pallet_xcm_benchmarks::generic pallet_xcm_benchmarks::fungible" has finished ✅ See logs here DetailsSubweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
karolk91
approved these changes
Jul 30, 2025
Contributor
|
@EleisonC, all looks good, thank you so much for this contribution. We would like to submit a referendum so you will receive a tip for your work here. In order to do this, please do one of the following (not both):
We will then try to make it happen |
Contributor
|
Contributor
Author
Hey @karolk91 @bkontur, Thank you for appreciating. I have added the Polkadot address to my profile (Option 2) |
auto-merge was automatically disabled
July 31, 2025 10:50
Pull Request is not mergeable
Merged
via the queue into
paritytech:master
with commit Jul 31, 2025
83dd8e3
267 of 270 checks passed
Contributor
|
@EleisonC thank you for your contribution. as a token of our appreciation we'd like to offer a DOT or KSM tip If you agree, please add a recipient Polkadot or Kusama address to the PRs description. Later edit: Ah, nevermind, I think it will work with the one you have set in your GitHub profile bio. Let me try. |
Contributor
|
/tip medium |
|
@acatangiu A referendum for a medium (80 DOT) tip was successfully submitted for @EleisonC (16JMzFbwMuLs8SooaTxiBZcd1e7HPUGchTBPtbDHk1Ubd9bT on polkadot). Referendum number: 1690. |
|
The referendum has appeared on Polkassembly. |
Contributor
Author
|
|
9 tasks
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Relates to: #9336, #7321 This PR aims to normalize result of `stringify` in scenarios when used inside nested macros to stringify token streams for benchmarking framework. Different versions of rust can include, or not, "space" characters around tokens like `<`,`>`,`::` so we are just removing additional spaces. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
… chain (#7321) ### Title: Update XCM benchmarks for sibling parachain delivery (closes #7211) ### Description: This PR updates XCM benchmarking configurations for testnet system parachains to reflect delivery to sibling parachains instead of the Parent relay chain. Integration: Replaced ToParentDeliveryHelper with ToParachainDeliveryHelper. Updated benchmark destinations --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Karol Kokoszka <karol.k91@gmail.com> Co-authored-by: Karol Kokoszka <karol@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Update XCM benchmarks for sibling parachain delivery (closes #7211)
Description:
This PR updates XCM benchmarking configurations for testnet system parachains to reflect delivery to sibling parachains instead of the Parent relay chain.
Integration:
Replaced ToParentDeliveryHelper with ToParachainDeliveryHelper.
Updated benchmark destinations