-
Notifications
You must be signed in to change notification settings - Fork 1.2k
XCM: Deny barrier checks for nested XCMs with specific instructions to be executed on the local chain #7200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
9c80770
PoC: DenyInstructionsWithXcm for validating nested XCM instructions
bkontur 6c79a06
PoC: DenyInstructionsWithXcm for validating nested XCM instructions
bkontur a98fc0d
Merge branch 'bko-deny-nested-xcm-barrier' of https://github.com/pari…
raymondkfcheung a70881e
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 72bec5b
Fix merge conflicts
raymondkfcheung 7aec7fe
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 6f60579
Update from raymondkfcheung running command 'fmt'
github-actions[bot] 06c7e65
Fix merge conflicts
raymondkfcheung 7bd8e10
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 2d3d33d
Update from raymondkfcheung running command 'fmt'
github-actions[bot] df64f5f
poc(XCM): Deny Nested XCM Barriers (#7351)
raymondkfcheung 797f868
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 72f8fe4
Refactor DenyInstructionsWithXcm with new NestedXcmType
raymondkfcheung 5fe41bc
Rename to DenyNestedLocalInstructions
raymondkfcheung 95ce08d
Remove NestedXcmType
raymondkfcheung 914ba61
Refactor DenyNestedXcmInstructions
raymondkfcheung 97f50a6
Refactor DenyNestedLocalInstructionsThenTry
raymondkfcheung 91d9541
Make DenyNestedXcmInstructions privately
raymondkfcheung 0866f2a
Update comments
raymondkfcheung b58f7a3
Update tests
raymondkfcheung 255a23a
Fix imports
raymondkfcheung b5d2777
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 4f8d0af
Update from raymondkfcheung running command 'prdoc --audience runtime…
github-actions[bot] 2a48a71
Move deny_execution logic to DenyNestedLocalInstructions
raymondkfcheung c6a363d
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 9ca64e7
Update config
raymondkfcheung 9601ee0
Update from raymondkfcheung running command 'fmt'
github-actions[bot] f2ff48d
Remove for regenerating
raymondkfcheung b75c40f
Update from raymondkfcheung running command 'prdoc --audience runtime…
github-actions[bot] a663b43
Update prdoc
raymondkfcheung 19e0b6f
Update prdoc
raymondkfcheung 9f4048d
Update prdoc
raymondkfcheung 211c0d8
Update prdoc
raymondkfcheung f4662da
Update from raymondkfcheung running command 'prdoc --audience runtime…
github-actions[bot] 1951b39
Update prdoc
raymondkfcheung f8009f1
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung c69d6c5
Update prdoc
raymondkfcheung fb948e4
Refactor DenyNestedXcmInstructions
raymondkfcheung f84b50a
Add more tests
raymondkfcheung 936e56e
Remove `mut`
raymondkfcheung 2994fe2
Update comment for DenyNestedXcmInstructions
raymondkfcheung 85a36a2
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 5443750
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung f3bf860
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung f2f8449
Add comment for RECURSION_LIMIT
raymondkfcheung 3f51889
Rename to DenyLocalInstructions
raymondkfcheung 7329db8
Move dummy filters to tests/barriers.rs
raymondkfcheung c518c59
Clean up tests
raymondkfcheung 632430e
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung c5ca5e7
Update prdoc
raymondkfcheung 24dd3e3
Remove DenyNestedLocalInstructionsThenTry
raymondkfcheung a1b3454
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 4c4b9ec
Rename to xcm
raymondkfcheung 63b0df1
Remove DenyNestedLocalInstructionsThenTry
raymondkfcheung 632f2b6
Remove DenyNestedXcmInstructions
raymondkfcheung 66af360
Apply fmt
raymondkfcheung 758e871
Simplify the recursion
raymondkfcheung 5a817a8
Update polkadot/xcm/xcm-builder/src/barriers.rs
bkontur c03412e
Merge branch 'master' into bko-deny-nested-xcm-barrier
bkontur ede0da7
Update prdoc/pr_7200.prdoc
bkontur b625ecc
Update prdoc/pr_7200.prdoc
bkontur 30d7688
Add scenario test
raymondkfcheung cc50283
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung d871197
Merge branch 'master' into bko-deny-nested-xcm-barrier
bkontur 5130c23
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 790b0ad
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung d10872b
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung a5aaee8
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung a9dc849
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 106561a
Update polkadot/xcm/xcm-builder/src/tests/barriers.rs
raymondkfcheung c8e5879
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 3b945a7
Add DenyNothing
raymondkfcheung 79f45bb
Rename to Executable
raymondkfcheung cf235c1
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 813d652
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 5abd904
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung ab72d64
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 7170543
Update polkadot/xcm/xcm-builder/src/barriers.rs
raymondkfcheung 19ef51c
Rename to DenyRecursively
raymondkfcheung 51e9c12
Update PR Doc
raymondkfcheung 1c21271
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung d75ce48
Update comments
raymondkfcheung 488636c
Flat the return of deny_recursively
raymondkfcheung 5ab11b9
Use flatten
raymondkfcheung f208bae
Revert to use unwrap_or
raymondkfcheung ff42492
Update comments
raymondkfcheung 1faaaf0
Fix format
raymondkfcheung acc8570
minor refactor
acatangiu e74fc03
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung 3268565
Use flatten
raymondkfcheung 8a76030
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung adb8068
Merge branch 'master' into bko-deny-nested-xcm-barrier
raymondkfcheung c31cefd
Update polkadot/xcm/xcm-executor/src/lib.rs
raymondkfcheung 5b4692d
Update prdoc/pr_7200.prdoc
raymondkfcheung bc92335
Update prdoc/pr_7200.prdoc
raymondkfcheung 864c58d
Update PR Doc
raymondkfcheung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raymondkfcheung let's do this also for: https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-executor/src/lib.rs#L803
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done