Skip to content

[stable2412] Backport #7158: Reject litep2p inbound requests from banned peers#7182

Merged
EgorPopelyaev merged 1 commit intostable2412from
backport-7158-to-stable2412
Jan 15, 2025
Merged

[stable2412] Backport #7158: Reject litep2p inbound requests from banned peers#7182
EgorPopelyaev merged 1 commit intostable2412from
backport-7158-to-stable2412

Conversation

@paritytech-cmd-bot-polkadot-sdk
Copy link
Contributor

Backport #7158 into stable2412 from lexnv.

See the documentation on how to use this bot.

This PR rejects inbound requests from banned peers (reputation is below
the banned threshold).

This mirrors the request-response implementation from the libp2p side.
I won't expect this to get triggered too often, but we'll monitor this
metric.

While at it, have registered a new inbound failure metric to have
visibility into this.

Discovered during the investigation of:
#7076 (comment)

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
(cherry picked from commit ef064a3)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 15, 2025
@github-actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@lexnv lexnv changed the title [stable2412] Backport #7158 [stable2412] Backport #7158: Reject litep2p inbound requests from banned peers Jan 15, 2025
@lexnv lexnv requested a review from EgorPopelyaev January 15, 2025 16:19
@EgorPopelyaev EgorPopelyaev merged commit 8c6dd56 into stable2412 Jan 15, 2025
@EgorPopelyaev EgorPopelyaev deleted the backport-7158-to-stable2412 branch January 15, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants