Skip to content

[pallet-revive] Add tracing support (1/3)#7166

Merged
athei merged 33 commits intomasterfrom
pg/add-tracing-support
Jan 17, 2025
Merged

[pallet-revive] Add tracing support (1/3)#7166
athei merged 33 commits intomasterfrom
pg/add-tracing-support

Conversation

@pgherveou
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou commented Jan 14, 2025

Add foundation for supporting call traces in pallet_revive

Follow up:

@pgherveou
Copy link
Copy Markdown
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-no-crate-publish-required The change does not require any crates to be re-published. labels Jan 14, 2025
@pgherveou pgherveou force-pushed the pg/add-tracing-support branch from 0ded99f to e07f355 Compare January 14, 2025 23:41
@pgherveou pgherveou changed the title [pallet-revive] Add tracing support [pallet-revive] Add tracing support 1/3 Jan 14, 2025
@pgherveou pgherveou changed the title [pallet-revive] Add tracing support 1/3 [pallet-revive] Add tracing support (1/3) Jan 14, 2025
@pgherveou pgherveou requested review from athei and xermicus January 15, 2025 13:28
Copy link
Copy Markdown
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from pg/replace-debug-trace to master January 15, 2025 18:11
@athei athei added this pull request to the merge queue Jan 17, 2025
@athei
Copy link
Copy Markdown
Member

athei commented Jan 17, 2025

Gotta love those random network errors inside the merge queue.

@athei athei removed this pull request from the merge queue due to a manual request Jan 17, 2025
@pgherveou pgherveou added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 17, 2025
@pgherveou pgherveou enabled auto-merge January 17, 2025 15:34
@pgherveou pgherveou disabled auto-merge January 17, 2025 16:50
@pgherveou pgherveou enabled auto-merge January 17, 2025 16:50
@pgherveou pgherveou added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@athei athei added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 7702fdd Jan 17, 2025
@athei athei deleted the pg/add-tracing-support branch January 17, 2025 20:43
pgherveou added a commit that referenced this pull request Jan 17, 2025
Add foundation for supporting call traces in pallet_revive

Follow up:
- PR #7167 Add changes to eth-rpc to introduce debug endpoint that will
use pallet-revive tracing features
- PR #6727 Add new RPC to the client and implement tracing runtime API
that can capture traces on previous blocks

---------

Co-authored-by: Alexander Theißen <[email protected]>
Nathy-bajo pushed a commit to Nathy-bajo/polkadot-sdk that referenced this pull request Jan 21, 2025
Add foundation for supporting call traces in pallet_revive

Follow up:
- PR paritytech#7167 Add changes to eth-rpc to introduce debug endpoint that will
use pallet-revive tracing features
- PR paritytech#6727 Add new RPC to the client and implement tracing runtime API
that can capture traces on previous blocks

---------

Co-authored-by: Alexander Theißen <[email protected]>
Nathy-bajo pushed a commit to Nathy-bajo/polkadot-sdk that referenced this pull request Jan 21, 2025
Add foundation for supporting call traces in pallet_revive

Follow up:
- PR paritytech#7167 Add changes to eth-rpc to introduce debug endpoint that will
use pallet-revive tracing features
- PR paritytech#6727 Add new RPC to the client and implement tracing runtime API
that can capture traces on previous blocks

---------

Co-authored-by: Alexander Theißen <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Feb 12, 2025
Add debug endpoint to eth-rpc for capturing a block or a single
transaction traces

See:
-  PR #7166

---------

Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Yuri Volkov <[email protected]>
Co-authored-by: Maksym H <[email protected]>
Co-authored-by: Santi Balaguer <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: xermicus <[email protected]>
clangenb pushed a commit to clangenb/polkadot-sdk that referenced this pull request Feb 19, 2025
Add debug endpoint to eth-rpc for capturing a block or a single
transaction traces

See:
-  PR paritytech#7166

---------

Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Yuri Volkov <[email protected]>
Co-authored-by: Maksym H <[email protected]>
Co-authored-by: Santi Balaguer <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: xermicus <[email protected]>
@chungquantin
Copy link
Copy Markdown
Contributor

Hi maintainers, I found that intercepting contract calls feature is removed in the PR and replaced with tracing, are there any alternative approach to do that in the revive?

@pgherveou
Copy link
Copy Markdown
Contributor Author

yes correct this has been removed, mainly to keep things simple for now, these kind of features can probably be built outside of the pallet too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T7-smart_contracts This PR/Issue is related to smart contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants