[pallet-revive] Fix caller_is_root return value#7086
Merged
athei merged 7 commits intoparitytech:masterfrom Jan 15, 2025
Merged
[pallet-revive] Fix caller_is_root return value#7086athei merged 7 commits intoparitytech:masterfrom
caller_is_root return value#7086athei merged 7 commits intoparitytech:masterfrom
Conversation
Contributor
Author
xermicus
reviewed
Jan 8, 2025
Co-authored-by: Cyrill Leutwiler <[email protected]>
xermicus
approved these changes
Jan 8, 2025
Member
xermicus
left a comment
xermicus
left a comment
There was a problem hiding this comment.
Thanks, this seems to be more consistent with other similar API methods.
You'll need to add major prdoc change (I think this constitutes a breaking change even though it only involves unstable methods).
Apparently there are no test fixtures for this.
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump major |
Contributor
|
Sorry, only members of the organization paritytech members can run commands. |
Contributor
Author
|
@xermicus Can you trigger the command above? |
Member
|
/cmd prdoc --audience runtime_dev --bump major |
xermicus
added
T7-smart_contracts
Contributor
|
Command "prdoc --audience runtime_dev --bump major" has failed ❌! See logs here |
Member
|
@cmichi the bot can't push to your branch. Can you add it manually (there is also the |
athei
reviewed
Jan 8, 2025
Member
athei
left a comment
athei
left a comment
There was a problem hiding this comment.
Should be a minor for pallet-revive (exporting a new type) and a major for pallet-revive-uapi. Just copy and edit prdoc stuff from past PRs to this pallet.
Contributor
|
Review required! Latest push from author must always be reviewed |
athei
approved these changes
Jan 8, 2025
xermicus
approved these changes
Jan 8, 2025
athei
approved these changes
Jan 15, 2025
xermicus
approved these changes
Jan 15, 2025
ordian
added a commit
that referenced
this pull request
Jan 16, 2025
* master: (33 commits) Implement `pallet-asset-rewards` (#3926) [pallet-revive] Add host function `to_account_id` (#7091) [pallet-revive] Remove revive events (#7164) [pallet-revive] Remove debug buffer (#7163) litep2p: Provide partial results to speedup GetRecord queries (#7099) [pallet-revive] Bump asset-hub westend spec version (#7176) Remove 0 as a special case in gas/storage meters (#6890) [pallet-revive] Fix `caller_is_root` return value (#7086) req-resp/litep2p: Reject inbound requests from banned peers (#7158) Add "run to block" tools (#7109) Fix reversed error message in DispatchInfo (#7170) approval-voting: Make importing of duplicate assignment idempotent (#6971) Parachains: Use relay chain slot for velocity measurement (#6825) PRDOC: Document `validate: false` (#7117) xcm: convert properly assets in xcmpayment apis (#7134) CI: Only format umbrella crate during umbrella check (#7139) approval-voting: Fix sending of assignments after restart (#6973) Retry approval on availability failure if the check is still needed (#6807) [pallet-revive-eth-rpc] persist eth transaction hash (#6836) litep2p: Sufix litep2p to the identify agent version for visibility (#7133) ...
Nathy-bajo
pushed a commit
to Nathy-bajo/polkadot-sdk
that referenced
this pull request
Jan 21, 2025
Closes paritytech#6767. The return type of the host function `caller_is_root` was denoted as `u32` in `pallet_revive_uapi`. This PR fixes the return type to `bool`. As a drive-by, the PR re-exports `pallet_revive::exec::Origin` to extend what can be tested externally. --------- Co-authored-by: Cyrill Leutwiler <[email protected]>
7 tasks
This was referenced Jul 16, 2025
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6767.
The return type of the host function
caller_is_rootwas denoted asu32inpallet_revive_uapi. This PR fixes the return type tobool.As a drive-by, the PR re-exports
pallet_revive::exec::Originto extend what can be tested externally.