[stable2412] Backport #7028#7067
Merged
EgorPopelyaev merged 3 commits intostable2412from Jan 14, 2025
Merged
Conversation
#7028) Currently `(A, B, C)` and `((A, B), C)` change the order of implications in the transaction extension pipeline. This order is not accessible in the metadata, because the metadata is just a vector of transaction extension, the nested structure is not visible. This PR make the implementation for tuple of `TransactionExtension` better for tuple of tuple. `(A, B, C)` and `((A, B), C)` don't change the implication for the validation A. This is a breaking change but only when using the trait `TransactionExtension` the code implementing the trait is not breaking (surprising rust behavior but fine). --------- Co-authored-by: command-bot <> Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit b5a5ac4)
paritytech-cmd-bot-polkadot-sdk
bot
requested a review
from a team
as a code owner
github-actions
bot
added
the
A3-backport
gui1117
reviewed
Jan 7, 2025
Contributor
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
Contributor
|
This backport is controversial, it is a breaking change both in rust code and in the runtime behavior in general.
|
acatangiu
previously approved these changes
Jan 7, 2025
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
Should be fine for 2412
georgepisaltu
previously approved these changes
Jan 7, 2025
Contributor
georgepisaltu
left a comment
georgepisaltu
left a comment
There was a problem hiding this comment.
As discussed, I think this change should make it into the release ASAP, especially because the feature is so new, which should mean we don't break anyone actually.
Contributor
|
cc @paritytech/release-engineering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #7028 into
stable2412from gui1117.See the documentation on how to use this bot.