[core-fellowship] Add permissionless import_member by ggwpez · Pull Request #7030 · paritytech/polkadot-sdk

ggwpez · 2025-01-02T11:44:19Z

Changes:

Add call import_member to the core-fellowship pallet.
Move common logic between import and import_member into do_import.

`import_member`

Can be used to induct an arbitrary collective member and is callable by any signed origin. Pays no fees upon success.
This is useful in the case that members did not induct themselves and are idling on their rank.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

substrate/frame/core-fellowship/src/lib.rs

Co-authored-by: Bastian Köcher <[email protected]>

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

prdoc/pr_7030.prdoc

gui1117

Needs to update the root doc:

//! - Pre-existing members may call `import` to have their rank recognised and be inducted into this
//!   pallet (to gain a salary and allow for eventual promotion).

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez · 2025-01-03T13:59:44Z

bot bench substrate-pallet --pallet=pallet_core_fellowship
bot bench cumulus-collectives --pallet=pallet_core_fellowship --runtime=collectives-westend
bot bench --help

command-bot · 2025-01-03T13:59:47Z

@ggwpez (outputHelp)

ggwpez · 2025-01-03T15:08:12Z

bot bench substrate-pallet --pallet=pallet_core_fellowship

command-bot · 2025-01-03T15:08:17Z

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7968166 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_core_fellowship. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 30-77144e9a-8bcd-4d80-9206-8b39ed233433 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2025-01-03T15:10:54Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_core_fellowship has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7968166 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7968166/artifacts/download.

ggwpez · 2025-01-03T17:08:03Z

/cmd bench-omni --runtime collectives-westend --pallet pallet_core_fellowship

github-actions · 2025-01-03T17:11:41Z

Command "bench-omni --runtime collectives-westend --pallet pallet_core_fellowship" has started 🚀 See logs here

…westend --pallet pallet_core_fellowship'

github-actions · 2025-01-03T17:31:45Z

Command "bench-omni --runtime collectives-westend --pallet pallet_core_fellowship" has finished ✅ See logs here

Details

Subweight results:

File	Extrinsic	Old	New	Change [%]
cumulus/pallets/collator-selection/src/weights.rs	leave_intent	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	new_session	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	register_as_candidate	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	set_invulnerables	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	take_candidate_slot	-	-	ERROR
cumulus/pallets/collator-selection/src/weights.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-rococo/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	take_candidate_slot	-	-	ERROR
cumulus/parachains/runtimes/people/people-westend/src/weights/pallet_collator_selection.rs	update_bond	-	-	ERROR
polkadot/runtime/westend/src/weights/pallet_preimage.rs	ensure_updated	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmen	-	-	ERROR
substrate/frame/election-provider-support/src/weights.rs	phragmms	-	-	ERROR
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	bump_offboard	661.00us	914.24us	+38.31
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	bump_demote	666.00us	915.23us	+37.42
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs	bump_demote	664.00us	912.34us	+37.40
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs	bump_offboard	675.00us	908.74us	+34.63
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	submit_evidence	194.00us	256.65us	+32.29
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	set_partial_params	111.00us	143.87us	+29.61
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs	set_partial_params	112.00us	143.94us	+28.52
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs	submit_evidence	202.00us	255.49us	+26.48
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	approve	379.00us	405.62us	+7.03
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	promote	835.00us	879.53us	+5.33
substrate/frame/core-fellowship/src/weights.rs	import_member		167.05us	Added
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_fellowship_core.rs	import_member		174.09us	Added
cumulus/parachains/runtimes/collectives/collectives-westend/src/weights/pallet_core_fellowship_ambassador_core.rs	import_member		173.68us	Added

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- collectives-westend: ['pallet_core_fellowship']

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez · 2025-01-06T10:43:02Z

/cmd bench-omni --pallet pallet_core_fellowship

github-actions · 2025-01-06T10:46:39Z

Command "bench-omni --pallet pallet_core_fellowship" has started 🚀 See logs here

github-actions · 2025-01-06T12:23:26Z

Command "bench-omni --pallet pallet_core_fellowship" has failed ❌! See logs here

Details

Command output:

✅ Successful benchmarks of runtimes/pallets:
-- dev: ['pallet_core_fellowship']
-- collectives-westend: ['pallet_core_fellowship']

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

paritytech-workflow-stopper · 2025-01-06T12:40:40Z

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12632544053
Failed job name: test-linux-stable

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* master: workflows: add debug input for sync templates act (#7057) Remove usage of `sp-std` from Substrate (#7043) Fix typos (#7027) [core-fellowship] Add permissionless import_member (#7030) Avoid incomplete block import pipeline with full verifying import queue (#7050)

[core-fellowship] Add permissionless import_member

0b62eb2

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez requested a review from a team as a code owner January 2, 2025 11:44

ggwpez added T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. labels Jan 2, 2025

ggwpez added 2 commits January 2, 2025 12:54

docs

139252c

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

prdoc + weights

d5f07e0

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

bkchr approved these changes Jan 2, 2025

View reviewed changes

substrate/frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved

substrate/frame/core-fellowship/src/lib.rs Show resolved Hide resolved

substrate/frame/core-fellowship/src/lib.rs Outdated Show resolved Hide resolved

ggwpez and others added 4 commits January 2, 2025 13:17

Update substrate/frame/core-fellowship/src/lib.rs

acb3569

Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/frame/core-fellowship/src/lib.rs

d9d3e18

Co-authored-by: Bastian Köcher <[email protected]>

Update substrate/frame/core-fellowship/src/lib.rs

9d6075a

Co-authored-by: Bastian Köcher <[email protected]>

fmt

5e09d14

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez commented Jan 2, 2025

View reviewed changes

prdoc/pr_7030.prdoc Outdated Show resolved Hide resolved

Update prdoc/pr_7030.prdoc

c597ec4

gui1117 approved these changes Jan 3, 2025

View reviewed changes

ggwpez added 3 commits January 3, 2025 14:25

review: update docs

90844f8

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

prdoc

062e509

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

allow deprecated

bacf946

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Update from ggwpez running command 'bench-omni --runtime collectives-…

9698220

…westend --pallet pallet_core_fellowship'

allow deprecated

b241535

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

seadanda approved these changes Jan 3, 2025

View reviewed changes

ggwpez added 2 commits January 6, 2025 13:31

Use weight from real runtime

10e8779

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

Merge branch 'master' into oty-permissionless-import

a725745

ggwpez enabled auto-merge January 6, 2025 12:31

weights

cba5d4f

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

ggwpez added this pull request to the merge queue Jan 6, 2025

Merged via the queue into master with commit 568231a Jan 6, 2025

ggwpez deleted the oty-permissionless-import branch January 6, 2025 15:03

ggwpez mentioned this pull request Jun 4, 2025

Bump to stable2503 polkadot-fellows/runtimes#711

Merged

7 tasks

github-actions bot mentioned this pull request Jun 10, 2025

Update polkadot-sdk from stable2412 to stable2503 moondance-labs/tanssi#1087

Closed

This was referenced Jul 16, 2025

Update polkadot-sdk from stable2412 to stable2503 moonbeam-foundation/moonbeam#3362

Closed

Update polkadot-sdk from stable2412 to stable2503-7 moonbeam-foundation/moonbeam#3363

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

Conversation

ggwpez commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

import_member

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gui1117 left a comment

Choose a reason for hiding this comment

Uh oh!

ggwpez commented Jan 3, 2025

Uh oh!

command-bot bot commented Jan 3, 2025

Uh oh!

ggwpez commented Jan 3, 2025

Uh oh!

command-bot bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jan 3, 2025

Uh oh!

ggwpez commented Jan 3, 2025

Uh oh!

github-actions bot commented Jan 3, 2025

Uh oh!

github-actions bot commented Jan 3, 2025

Uh oh!

ggwpez commented Jan 6, 2025

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

paritytech-workflow-stopper bot commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ggwpez commented Jan 2, 2025 •

edited

Loading

`import_member`

command-bot bot commented Jan 3, 2025 •

edited

Loading