Omni-node: Detect pending code in storage and send go ahead signal in dev-mode.#6885
Merged
Omni-node: Detect pending code in storage and send go ahead signal in dev-mode.#6885
Conversation
Contributor
Author
|
/cmd prdoc --bump patch --audience runtime_dev |
bkchr
reviewed
Dec 13, 2024
Comment on lines
+161
to
+163
| let should_send_go_ahead = client_for_cidp | ||
| .storage(block, &StorageKey(PENDING_VALIDATION_CODE_KEY.to_vec())) | ||
| .ok() |
Member
There was a problem hiding this comment.
If someone names ParachainSystem differently in construct_runtime!, this will fail.
IMO it is better to call collect_collation_info at block and check if new_validation_code is Some(_).
Contributor
Author
There was a problem hiding this comment.
I was totally willing to take that risk :D. But yeah your idea is better. Not checking the runtime api version though, 3 year old runtimes with the manual seal of omni node seems exotic.
kianenigma
approved these changes
Dec 13, 2024
Contributor
There was a problem hiding this comment.
Thank you very much!
Would be great to backport this into the next patch of 202412 so it can be used in documentation
update: bot should open the PR automatically: https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md
bkchr
approved these changes
Dec 16, 2024
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6885-to-stable2407
git worktree add --checkout .worktree/backport-6885-to-stable2407 backport-6885-to-stable2407
cd .worktree/backport-6885-to-stable2407
git reset --hard HEAD^
git cherry-pick -x cee63ac0a34f356c66f1305073fa3d1210550a0c
git push --force-with-lease |
Contributor
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6885-to-stable2409
git worktree add --checkout .worktree/backport-6885-to-stable2409 backport-6885-to-stable2409
cd .worktree/backport-6885-to-stable2409
git reset --hard HEAD^
git cherry-pick -x cee63ac0a34f356c66f1305073fa3d1210550a0c
git push --force-with-lease |
Contributor
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Dec 16, 2024
Backport #6885 into `stable2412` from skunert. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
… dev-mode. (paritytech#6885) We check if there is a pending validation code in storage. If there is, add the go-ahead signal in the relay chain storage proof. Not super elegant, but should get the job done for development. --------- Co-authored-by: command-bot <>
undercover-cactus
added a commit
to Moonsong-Labs/storage-hub
that referenced
this pull request
Apr 30, 2025
undercover-cactus
added a commit
to Moonsong-Labs/storage-hub
that referenced
this pull request
May 21, 2025
* rename `state_version` to `system_version` for xcm-simulator * replace 'sp_runtime::RuntimeString' with 'alloc::string::String' (see paritytech/polkadot-sdk#5693) * missed a place to rename state_version to system_version * update dry_run_call to include xcm result version (see paritytech/polkadot-sdk#7438) * introduce SelectCore into the runtime for the parachain system pallet (see paritytech/polkadot-sdk#8153) * introduce DoneSlashHandler in the runtime for the balances pallet and set it empty because we are not using it (see paritytech/polkadot-sdk#5623) * introduce WeightInfo type for transaction pallets which is part of the biggest change regarding the TransactionExtension (see paritytech/polkadot-sdk#3685) * fix conversion from String to str * replicate the changes in xcm-simulator * DispatchInfo is now DispatchEventInfo in the client (see paritytech/polkadot-sdk#3685) * sc_offchain::Offchainworker::new() now return Result fix (see paritytech/polkadot-sdk#5919) * Update TransactionPool build to work with the new pool struct (see paritytech/polkadot-sdk#4639) * fix instant sealing command * enable runtime upgrade in dev mode (see paritytech/polkadot-sdk#6885) * check for default backend network when starting node * fix unresolved import in benchmarking * fix format error in benchmarking * fix mock pallets * fixing xcm simulator * forgot to save file before commit * fix xcm test * upgrade @PolkaDot to 15.10.2; fix typegen; * update utils polkadot deps * attempting to fix zombienet * use a more recent polkadot binary * install stable2412 binary in CI too * fix fee in reaping account test * typegen * fix last test * remove console.log; use rpc_port config everywhere * spec version updated in test --------- Co-authored-by: Facundo Farall <37149322+ffarall@users.noreply.github.com>
This was referenced Jul 16, 2025
margaretphillips96627margaretphillips
added a commit
to margaretphillips96627margaretphillips/storage-hub
that referenced
this pull request
Oct 6, 2025
* rename `state_version` to `system_version` for xcm-simulator * replace 'sp_runtime::RuntimeString' with 'alloc::string::String' (see paritytech/polkadot-sdk#5693) * missed a place to rename state_version to system_version * update dry_run_call to include xcm result version (see paritytech/polkadot-sdk#7438) * introduce SelectCore into the runtime for the parachain system pallet (see paritytech/polkadot-sdk#8153) * introduce DoneSlashHandler in the runtime for the balances pallet and set it empty because we are not using it (see paritytech/polkadot-sdk#5623) * introduce WeightInfo type for transaction pallets which is part of the biggest change regarding the TransactionExtension (see paritytech/polkadot-sdk#3685) * fix conversion from String to str * replicate the changes in xcm-simulator * DispatchInfo is now DispatchEventInfo in the client (see paritytech/polkadot-sdk#3685) * sc_offchain::Offchainworker::new() now return Result fix (see paritytech/polkadot-sdk#5919) * Update TransactionPool build to work with the new pool struct (see paritytech/polkadot-sdk#4639) * fix instant sealing command * enable runtime upgrade in dev mode (see paritytech/polkadot-sdk#6885) * check for default backend network when starting node * fix unresolved import in benchmarking * fix format error in benchmarking * fix mock pallets * fixing xcm simulator * forgot to save file before commit * fix xcm test * upgrade @PolkaDot to 15.10.2; fix typegen; * update utils polkadot deps * attempting to fix zombienet * use a more recent polkadot binary * install stable2412 binary in CI too * fix fee in reaping account test * typegen * fix last test * remove console.log; use rpc_port config everywhere * spec version updated in test --------- Co-authored-by: Facundo Farall <37149322+ffarall@users.noreply.github.com>
dominic5perezd
added a commit
to dominic5perezd/storage-hub
that referenced
this pull request
Oct 10, 2025
* rename `state_version` to `system_version` for xcm-simulator * replace 'sp_runtime::RuntimeString' with 'alloc::string::String' (see paritytech/polkadot-sdk#5693) * missed a place to rename state_version to system_version * update dry_run_call to include xcm result version (see paritytech/polkadot-sdk#7438) * introduce SelectCore into the runtime for the parachain system pallet (see paritytech/polkadot-sdk#8153) * introduce DoneSlashHandler in the runtime for the balances pallet and set it empty because we are not using it (see paritytech/polkadot-sdk#5623) * introduce WeightInfo type for transaction pallets which is part of the biggest change regarding the TransactionExtension (see paritytech/polkadot-sdk#3685) * fix conversion from String to str * replicate the changes in xcm-simulator * DispatchInfo is now DispatchEventInfo in the client (see paritytech/polkadot-sdk#3685) * sc_offchain::Offchainworker::new() now return Result fix (see paritytech/polkadot-sdk#5919) * Update TransactionPool build to work with the new pool struct (see paritytech/polkadot-sdk#4639) * fix instant sealing command * enable runtime upgrade in dev mode (see paritytech/polkadot-sdk#6885) * check for default backend network when starting node * fix unresolved import in benchmarking * fix format error in benchmarking * fix mock pallets * fixing xcm simulator * forgot to save file before commit * fix xcm test * upgrade @PolkaDot to 15.10.2; fix typegen; * update utils polkadot deps * attempting to fix zombienet * use a more recent polkadot binary * install stable2412 binary in CI too * fix fee in reaping account test * typegen * fix last test * remove console.log; use rpc_port config everywhere * spec version updated in test --------- Co-authored-by: Facundo Farall <37149322+ffarall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We check if there is a pending validation code in storage. If there is, add the go-ahead signal in the relay chain storage proof.
Not super elegant, but should get the job done for development.