Skip to content

Add fallback_weight to the log #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkontur merged 3 commits into from
Dec 10, 2024
Merged

Add fallback_weight to the log #6782

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70b35fd
Add fallback_weight to the log
bkontur Dec 7, 2024
5325bfa
Merge branch 'master' into bko-fallback-weight-to-log
bkontur Dec 9, 2024
fa30ee7
Update polkadot/xcm/src/v4/mod.rs
bkontur Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions polkadot/xcm/src/v4/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,12 +1320,14 @@ impl<Call: Decode + GetDispatchInfo> TryFrom<NewInstruction<Call>> for Instructi
let require_weight_at_most = match call.take_decoded() {
Ok(decoded) => decoded.get_dispatch_info().call_weight,
Err(error) => {
let fallback_weight = fallback_max_weight.unwrap_or(Weight::MAX);
log::error!(
target: "xcm::versions::v5Tov4",
"Couldn't decode call in Transact: {:?}, using fallback weight.",
"Couldn't decode call in Transact: {:?}, using fallback weight: {:?}",
error,
fallback_weight,
);
fallback_max_weight.unwrap_or(Weight::MAX)
fallback_weight
},
};
Self::Transact { origin_kind, require_weight_at_most, call: call.into() }
Expand Down