Skip to content

Add stable2412 to target_branches for command-backport.yml#6666

Merged
bkontur merged 1 commit intomasterfrom
bko-add-stable2412-to-backports
Nov 27, 2024
Merged

Add stable2412 to target_branches for command-backport.yml#6666
bkontur merged 1 commit intomasterfrom
bko-add-stable2412-to-backports

Conversation

@bkontur
Copy link
Copy Markdown
Contributor

@bkontur bkontur commented Nov 27, 2024

The backport bot opens PR for A4-needs-backport only for stable2407 stable2409, but we have already stable2412.

The question is, when should we append a new stable* branch here? Should it be done when a new stable* branch is created? Can we automate this process somehow?

@bkontur bkontur added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Nov 27, 2024
@bkontur bkontur requested review from a team as code owners November 27, 2024 08:37
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Nov 27, 2024

I had to create backport PR to stable2412 manually, but then the bot complains: #6649 (comment)

  This pull request is amending an existing release. Please proceed with extreme caution,
  as to not impact downstream teams that rely on the stability of it. Some things to consider:
  - Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  - Should be a legit *fix* for some  bug, not adding tons of new features.
  - Must either be already audited or not need an audit.

  <details><summary><i>Emergency Bypass</i></summary>
  <p>

  If you really need to bypass this check: add <code>validate: false</code> to each crate
  in the Prdoc where a breaking change is introduced. This will release a new major
  version of that crate and all its reverse dependencies and basically break the release.

  </p>
  </details> 

@bkontur bkontur enabled auto-merge November 27, 2024 09:02
@bkontur bkontur added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 445c1c8 Nov 27, 2024
@bkontur bkontur deleted the bko-add-stable2412-to-backports branch November 27, 2024 10:19
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
…h#6666)

The backport bot opens PR for `A4-needs-backport` only for stable2407
stable2409, but we have already stable2412.

The question is, when should we append a new `stable*` branch here?
Should it be done when a new `stable*` branch is created? Can we
automate this process somehow?
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
…h#6666)

The backport bot opens PR for `A4-needs-backport` only for stable2407
stable2409, but we have already stable2412.

The question is, when should we append a new `stable*` branch here?
Should it be done when a new `stable*` branch is created? Can we
automate this process somehow?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants