-
Notifications
You must be signed in to change notification settings - Fork 1.2k
rpc server: fix subscription id_provider being reset to default one. #6588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6fcb648
fix: id_provider being reset to default one.
TarekkMA bce99f9
add a prdoc
TarekkMA 1db6ea9
fix prdoc
TarekkMA 2d710c0
fix prdoc
TarekkMA 2af4a8b
Update substrate/client/rpc-servers/src/lib.rs
niklasad1 61692e5
Update prdoc/pr_6588.prdoc
niklasad1 ee24a59
Update substrate/client/rpc-servers/src/lib.rs
niklasad1 f4b8611
remove mut
TarekkMA a1ae94d
Update prdoc/pr_6588.prdoc
niklasad1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 | ||
| # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json | ||
|
|
||
| title: Fix id_provider being reset to default one. | ||
|
|
||
| doc: | ||
| - audience: Node Dev | ||
| description: | | ||
| The modification ensures that the id_provider variable is cloned instead of taken, which can help prevent issues related id provider being reset to the default. | ||
|
|
||
|
|
||
| crates: | ||
| - name: sc-rpc-server | ||
| bump: patch | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.