Skip to content

Remove debug message about pruning active leaves #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreiEres merged 4 commits into from
Nov 13, 2024
Merged

Remove debug message about pruning active leaves #6440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0f1fa3
Remove debug message about pruning active leaves
AndreiEres Nov 11, 2024
fa21eed
Update from AndreiEres running command 'prdoc --audience node_dev --b…
actions-user Nov 12, 2024
43ac2dc
Update prdoc
AndreiEres Nov 13, 2024
50102ae
Merge branch 'master' into AndreiEres/remove-queue-active-leaves-debug
AndreiEres Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions polkadot/node/core/pvf/src/execute/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,6 @@ impl Queue {
for hash in &update.deactivated {
let _ = self.active_leaves.remove(&hash);
}

gum::debug!(target: LOG_TARGET, size = ?self.active_leaves.len(), "Active leaves pruned");
Copy link
Copy Markdown
Contributor

@sandreim sandreim Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also make this a trace to get less noise.

Copy link
Copy Markdown
Contributor

@sandreim sandreim Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if you are 100% sure we never need to debug this in prod, I guess it's fine

Copy link
Copy Markdown
Contributor

@lexnv lexnv Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we could downgrade this or move to a separate log-target for "extra" details, maybe it will come in handy in the future, up to you 🙏

}

fn insert_active_leaf(&mut self, update: ActiveLeavesUpdate, ancestors: Vec<Hash>) {
Expand Down
8 changes: 8 additions & 0 deletions prdoc/pr_6440.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Remove debug message about pruning active leaves
doc:
- audience: Node Dev
description: |-
Removed useless debug message
crates:
- name: polkadot-node-core-pvf
validate: false