wasm-builder: Use riscv32emac-unknown-none-polkavm.json target

[jarkkojs]

Description

Closes #6335.

Integration

N/A

Review Notes

RuntimeTarget is converted to return path to the custom target JSON file

[jarkkojs]

How do I pass check-labels?

[koute]

How do I pass check-labels?

If you click on the job it tells you why it fails:

You need to include some of the T* label(s)

AFAIK, here is the repo with the rules, and here are some docs.

[jarkkojs]

After change max-atomic-width to 64:

  thread 'main' panicked at substrate/utils/wasm-builder/src/wasm_project.rs:946:21:
  internal error: couldn't read the metadata of "/home/jarkko/work/github.com/jarkkojs/polkadot-sdk/substrate/utils/wasm-builder/riscv32emac-unknown-none-polkavm.json/release/kitchensink-runtime-blob": Not a directory (os error 20)
  stack backtrace:
     0: rust_begin_unwind
     1: core::panicking::panic_fmt
     2: substrate_wasm_builder::wasm_project::build_bloaty_blob
     3: substrate_wasm_builder::wasm_project::create_and_compile
     4: substrate_wasm_builder::builder::build_project
     5: substrate_wasm_builder::builder::WasmBuilder::build
     6: substrate_wasm_builder::builder::WasmBuilder::build_using_defaults
     7: build_script_build::main
     8: core::ops::function::FnOnce::call_once
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
( RUST_BACKTRACE=1 SUBSTRATE_RUNTIME_TARGET=riscv SUBSTRATE_ENABLE_POLKAVM=1 )  1341.20s user 124.56s system 570% cpu 4:16.75 total

[athei]

So the issue here is compiling PolkaVM itself to risc32emac? Since the kitchensink runtime uses PolkaVM to run contracts?

[jarkkojs]

So the issue here is compiling PolkaVM itself to risc32emac? Since the kitchensink runtime uses PolkaVM to run contracts?

I th

How do I pass check-labels?

If you click on the job it tells you why it fails:

You need to include some of the T* label(s)

AFAIK, here is the repo with the rules, and here are some docs.

Aah so labels are labels in Github? OK cool I thought I has something missing in the commit itself.

[athei]

Yes it checks that you have all the required github labels

[jarkkojs]

@koute looking pretty good but i don't know what the remaining error messages even mean :-)

Summary of remaining issues:

• continuous-integration/gitlab-zombienet: all of the three simply timeout
• Build Misc / build-runtimes-polkavm: Failed to write metrics: promwrite: sending remote write request: Post "placeholder": unsupported protocol scheme ""
• Build Misc / All build misc jobs passed: Failed to write metrics: promwrite: sending remote write request: Post "placeholder": unsupported protocol scheme ""

[athei]

They seem all to be unrelated to your changes. The CI is notoriously flaky. Merging master and praying is what you do in these cases.

[athei]

I am confused that this even works. The polkavm-linker and polkavm-derive dependencies is still set to 0.9.3. Shouldn't it be bumped in this PR, too?

polkadot-sdk/Cargo.toml

Lines 1093 to 1094 in a1af8ed

	polkavm-derive = "0.9.1"
	polkavm-linker = "0.9.2"

[jarkkojs]

I am confused that this even works. The polkavm-linker and polkavm-derive dependencies is still set to 0.9.3. Shouldn't it be bumped in this PR, too?

polkadot-sdk/Cargo.toml

Lines 1093 to 1094 in a1af8ed

	polkavm-derive = "0.9.1"
	polkavm-linker = "0.9.2"

I have no idea, @koute ?

[koute]

https://github.com/paritytech/polkadot-sdk/actions/runs/11835548683/job/32978647159?pr=6419#step:5:988

Looks like the build runtime tests are failing, so yes, the derive and the linker crates should also be bumped.

[jarkkojs]

https://github.com/paritytech/polkadot-sdk/actions/runs/11835548683/job/32978647159?pr=6419#step:5:988

Looks like the build runtime tests are failing, so yes, the derive and the linker crates should also be bumped.

@koute, @athei

I posted this on Tuesday:

#6419 (comment)

I.e. still not knowing what to do (day three).

[athei]

Answered here: #6419 (comment)

[StackOverflowExcept1on]

@bkchr @jarkkojs What is the point of doing -Zbuild-std for target riscv32emac-unknown-none-polkavm? It increases runtime build time for non-wasm targets.

[athei]

It is required for both targets but for different reasons:

wasm: The rustup provided standard library is compiled with wasm extensions enabled we dont support. Hence we need to recompile it.

riscv: Rustup doesn't contain any prebuilt binaries for this target. Hence we need to build it ourselves.

[jarkkojs]

Yeah, so I guessed, i.e. it should be official target in rustc upstream to have prebuilt binaries, right?

[jarkkojs]

[not actually at work yet, my keyboard just writes by itself]

[StackOverflowExcept1on]

@athei Thanks for the clarification! I think Parity could add to the pre-compiled libraries to riscv32emac-unknown-none-polkavm target in rlib format like the wasm32-unknown-unknown target does (located in ./lib/rustlib/wasm32-unknown-unknown/lib/libcore-192e883b194683b6.rlib).