Conversation
alindima
added
I2-bug
sandreim
approved these changes
Oct 31, 2024
Contributor
sandreim
left a comment
sandreim
left a comment
There was a problem hiding this comment.
LGTM, just some suggestions.
eskimor
approved these changes
Nov 4, 2024
| } | ||
|
|
||
| /// Expected claim queue len. Can be different than the real length if for example we don't have | ||
| /// assignments for a core. |
Member
There was a problem hiding this comment.
claim_queue_len is a bit confusing as usually we mean by length of the claim queue the length of individual queues.
If we want to name it with regrads to claim queue, maybe claim_queue_cores?
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in #6161 (comment)
Fixes a bug introduced in #5461, where the claim queue would contain entries even if the validator groups storage is empty (which happens during the first session).
This PR sets the claim queue core count to be the minimum between the num_cores param and the number of validator groups
TODO: