Upgrade Proxy and Multisig pallets to Benchmarking V2#6018
Merged
re-gius merged 8 commits intokiz-frame-umbrella-in-palletsfrom Oct 15, 2024
Merged
Upgrade Proxy and Multisig pallets to Benchmarking V2#6018re-gius merged 8 commits intokiz-frame-umbrella-in-palletsfrom
re-gius merged 8 commits intokiz-frame-umbrella-in-palletsfrom
Conversation
re-gius
added
T2-pallets
seadanda
reviewed
Oct 11, 2024
Contributor
seadanda
left a comment
seadanda
left a comment
There was a problem hiding this comment.
Looks like a few things need to be tidied up - make sure you're passing --features=runtime-benchmarks when you check
Co-authored-by: Dónal Murray <donal.murray@parity.io>
gui1117
approved these changes
Oct 12, 2024
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
CI needs to pass, but looks good otherwise.
Contributor
|
Review required! Latest push from author must always be reviewed |
kianenigma
approved these changes
Oct 15, 2024
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Thank you!
Last question:
Please check the rust-doc of the each macro respectively, and see if the docs are sufficient and/or can be improved? Some ideas
- Does the v1 one mention the existence of v2?
- Is there a good "migration" guide available or noted anywhere?
If CI checks are not relevant, we can merge this anyways, as the target branch is not master.
shawntabrizi
approved these changes
Oct 15, 2024
…hmarking-pallets-pm
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
# Adding instruction to migrate benchmarking from v1 to v2 Even if the documentation for benchmarking v1 and v2 is clear and detailed, I feel that adding a migration guide from v1 to v2 would help doing it quicker. ## Integration This change only affects documentation, so it does not cause integration issues. ## Review Notes I followed the migration procedure I applied in PR #6018 . I added everything from there, but I may be missing some extra steps that are needed in specific case, so in case you notice something please let me know. --------- Co-authored-by: Dónal Murray <donal.murray@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-task of PR #5995
Integration
These changes should not require any integration effort.