Skip to content

Fix u256 conversion in BABE #5994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 4 commits into from
Oct 9, 2024
Merged

Fix u256 conversion in BABE #5994

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff54875
Fix u256 conversion in BABE randomness
ordian Oct 9, 2024
61bb404
satisfy semver check
ordian Oct 9, 2024
28eda98
Add a test
bkchr Oct 9, 2024
531e5e2
Merge branch 'master' into ao-5886-followup
bkchr Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion substrate/client/consensus/babe/src/authorship.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ pub(super) fn secondary_slot_author(
}

let rand =
U256::from_little_endian(&(randomness, slot).using_encoded(sp_crypto_hashing::blake2_256));
U256::from_big_endian(&(randomness, slot).using_encoded(sp_crypto_hashing::blake2_256));

let authorities_len = U256::from(authorities.len());
let idx = rand % authorities_len;
Expand Down