Remove periodic tick from SyncingEngine#5962
Open
ndkazu wants to merge 15 commits intoparitytech:masterfrom
Open
Remove periodic tick from SyncingEngine#5962ndkazu wants to merge 15 commits intoparitytech:masterfrom
SyncingEngine#5962ndkazu wants to merge 15 commits intoparitytech:masterfrom
Conversation
Contributor
Author
|
@dmitry-markin , thanks to recent changes this became a pretty simple PR. Should be an easy-fast review... |
ndkazu
changed the title
SyncingEngine #5451SyncingEngine
Contributor
|
Thanks @ndkazu! I see some tests fail in the CI, including warp sync in test linux stable. Let's merge master and see if it helps. |
Contributor
Author
yeah, warp_sync test is not working, even locally.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#5451
Description
This PR removes periodic tick from
SyncingEngine:The initial context can be found below:
#5410 (comment) .