Conversation
mordamax
force-pushed
the
mak-fix-cmd-regex
branch
from
457c038 to
f5e3ad7
Compare
mordamax
changed the title
bkchr
reviewed
Oct 6, 2024
|
|
||
| parser.add_argument("--pr", type=int, required=pr_required, help="The PR number to generate the PrDoc for.") | ||
| parser.add_argument("--audience", type=str, nargs='*', choices=allowed_audiences, default=["todo"], help="The audience of whom the changes may concern. Example: --audience runtime_dev node_dev") | ||
| parser.add_argument("--bump", type=str, default="major", choices=["patch", "minor", "major", "silent", "ignore", "no_change"], help="A default bump level for all crates. Example: --bump patch") |
Member
There was a problem hiding this comment.
Would be nice if this could be taken from the CI check. Aka to take the bump as determined by the tool.
Contributor
Author
There was a problem hiding this comment.
yep, i also thought about it
Contributor
Author
There was a problem hiding this comment.
I think i'll try to do this within paritytech/prdoc#46
mordamax
commented
Oct 7, 2024
mordamax
added
the
R0-no-crate-publish-required
AndWeHaveAPlan
approved these changes
Oct 7, 2024
bkchr
approved these changes
Oct 7, 2024
alvicsam
approved these changes
Oct 8, 2024
ggwpez
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5924 (comment)
improve prdoc arguments validation & help:
Test evidence: paritytech-stg@6dd274e