Skip to content

Do not enforce PoV size hard limit in config #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s0me0ne-unkn0wn merged 7 commits into from
Oct 2, 2024
Merged

Do not enforce PoV size hard limit in config #5887

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
01e29ab
Do not enforce PoV size hard limit in config
s0me0ne-unkn0wn Oct 1, 2024
5af42ea
Fix types
s0me0ne-unkn0wn Oct 1, 2024
b0de255
Use local constant
s0me0ne-unkn0wn Oct 1, 2024
bee3c08
Merge remote-tracking branch 'origin/master' into s0me0ne/max-pov-siz…
s0me0ne-unkn0wn Oct 2, 2024
1db41ef
Remove unused import
s0me0ne-unkn0wn Oct 2, 2024
791f4bc
Add prdoc
s0me0ne-unkn0wn Oct 2, 2024
f8c5489
Microfixes
s0me0ne-unkn0wn Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion polkadot/runtime/parachains/src/configuration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ use polkadot_primitives::SchedulerParams;

const LOG_TARGET: &str = "runtime::configuration";

// This value is derived from network layer limits. See `sc_network::MAX_RESPONSE_SIZE` and
// `polkadot_node_network_protocol::POV_RESPONSE_SIZE`.
const POV_SIZE_HARD_LIMIT: u32 = 16 * 1024 * 1024;

/// All configuration of the runtime with respect to paras.
#[derive(
Clone,
Expand Down Expand Up @@ -377,7 +381,7 @@ where
})
}

if self.max_pov_size > MAX_POV_SIZE {
if self.max_pov_size > POV_SIZE_HARD_LIMIT {
return Err(MaxPovSizeExceedHardLimit { max_pov_size: self.max_pov_size })
}

Expand Down