Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
This reverts commit 9aa865f.
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
… into oty-omni-bencher-fix2
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
the
T12-benchmarks
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
skunert
reviewed
Oct 2, 2024
Contributor
skunert
left a comment
skunert
left a comment
There was a problem hiding this comment.
One thing I noticed is that we currently have no way to use the default preset of any runtime. You can only specify a specific patch or nothing at all.
| "bench_features": "runtime-benchmarks", | ||
| "template": "cumulus/templates/xcm-bench-template.hbs", | ||
| "bench_features": "runtime-benchmarks", | ||
| "bench_flags": "--genesis-builder-policy=none --exclude-pallets=pallet_xcm", |
Contributor
There was a problem hiding this comment.
Hmm I have to say I don't really understand why we are using genesis-builder-policy=none. It will use an empty genesis, why do we want that?
Member
Author
There was a problem hiding this comment.
We use none for the runtimes that dont yet support the genesis builder pattern. It is just to make the benchmarks run at all, otherwise it just errors that there are no presets. That is why i only added it to some runtimes.
Member
Author
There was a problem hiding this comment.
After DMin i will try it with the chain specs, maybe those work.
Member
Author
There was a problem hiding this comment.
The specs are not compiled with the benchmarking features, so that does not work either.
mordamax
approved these changes
Oct 4, 2024
alvicsam
approved these changes
Oct 7, 2024
mordamax
reviewed
Oct 7, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Maksym H <[email protected]>
kianenigma
reviewed
Oct 7, 2024
kianenigma
approved these changes
Oct 7, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Contributor
|
Can we remove short benchmarks from gitlab? |
Contributor
i think yes 
https://github.com/paritytech/polkadot-sdk/actions/runs/11239542155
|
ordian
added a commit
that referenced
this pull request
Oct 11, 2024
* master: (28 commits) `substrate-node`: removed excessive polkadot-sdk features (#5925) Rename QueueEvent::StartWork (#6015) [ci] Remove quick-benchmarks-omni from GitLab (#6014) Set larger timeout for cmd.yml (#6006) Fix `0003-beefy-and-mmr` test (#6003) Remove redundant XCMs from dry run's forwarded xcms (#5913) Add RadiumBlock bootnodes to Coretime Polkadot Chain spec (#5967) Bump strum from 0.26.2 to 0.26.3 (#5943) Add PVF execution priority (#4837) Snowbridge V2 docs (#5902) Fix u256 conversion in BABE (#5994) [ci] Move test-linux-stable-no-try-runtime to GHA (#5979) Bump PoV request timeout (#5924) [Release/CI] Github flow to build `polkadot`/`polkadot-parachain` rc binaries and deb package (#5963) [ci] Remove short-benchmarks from Gitlab (#5988) Disable flaky tests reported in 5972/5973/5974 (#5976) Bump some dependencies (#5886) bump zombienet version and set request for k8s (#5968) [omni-bencher] Make all runtimes work (#5872) Omni-Node renamings (#5915) ...
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
--exclude-palletsto exclude some pallets from runtimes where we dont have genesis presets yet--genesis-builder-policy=nonework with--runtime