Skip to content

[stable2409] Backport #5594#5767

Merged
bkchr merged 1 commit intostable2409from
backport-5594-to-stable2409
Sep 19, 2024
Merged

[stable2409] Backport #5594#5767
bkchr merged 1 commit intostable2409from
backport-5594-to-stable2409

Conversation

@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot commented Sep 19, 2024

Backport #5594 into stable2409 from Moliholy.

See the documentation on how to use this bot.

@bkchr @github-actions
Add debugging info for StorageWeightReclaim (#5594)
f99678e 
When inspecting the logs we often encounter the following message:

`Benchmarked storage weight smaller than consumed storage weight.
benchmarked: {benchmarked_weight} consumed: {consumed_weight} unspent:
{unspent}`

However, it is very hard to guess which call is causing the issue.

With the changes proposed in this PR, information about the call is
provided so that we can easily identify the source of the problem
without further delay, and this way work more efficiently in solving the
issue.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
(cherry picked from commit 016421a)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 19, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 19, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@bkchr bkchr merged commit c9fbeb7 into stable2409 Sep 19, 2024
@bkchr bkchr deleted the backport-5594-to-stable2409 branch September 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

Assignees

No one assigned

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bkchr