Improve APIs for Tries in Runtime#5756
Merged
shawntabrizi merged 104 commits intomasterfrom Sep 30, 2024
Merged
Conversation
This reverts commit 1cfb29f.
Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
…abrizi/polkadot-sdk into shawntabrizi-proving-trie
…tech/polkadot-sdk into shawntabrizi-binary-trie2
…tech/polkadot-sdk into shawntabrizi-binary-trie2
…tech/polkadot-sdk into shawntabrizi-binary-trie2
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paritytech-ci
pushed a commit
that referenced
this pull request
Oct 1, 2024
This is a refactor and improvement from: #3881 - `sp_runtime::proving_trie` now exposes a `BasicProvingTrie` for both `base2` and `base16`. - APIs for `base16` are more focused on single value proofs, also aligning their APIs with the `base2` trie - A `ProvingTrie` trait is included which wraps both the `base2` and `base16` trie, and exposes all APIs needed for an end to end scenario. - A `ProofToHashes` trait is exposed which can allow us to write proper benchmarks for the merkle trie. --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor and improvement from: #3881
sp_runtime::proving_trienow exposes aBasicProvingTriefor bothbase2andbase16.base16are more focused on single value proofs, also aligning their APIs with thebase2trieProvingTrietrait is included which wraps both thebase2andbase16trie, and exposes all APIs needed for an end to end scenario.ProofToHashestrait is exposed which can allow us to write proper benchmarks for the merkle trie.