Skip to content

[stable2409] Backport #5580#5733

Merged
ggwpez merged 1 commit intostable2409from
backport-5580-to-stable2409
Sep 17, 2024
Merged

[stable2409] Backport #5580#5733
ggwpez merged 1 commit intostable2409from
backport-5580-to-stable2409

Conversation

@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

Backport #5580 into stable2409 from gui1117.

See the documentation on how to use this bot.

Explicitly give the types in some generated code so that the error shows
up good when user code is wrong.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
(cherry picked from commit aec2b10)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot requested a review from a team as a code owner September 16, 2024 16:08
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggwpez ggwpez merged commit a869596 into stable2409 Sep 17, 2024
@ggwpez ggwpez deleted the backport-5580-to-stable2409 branch September 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants