Skip to content

v16: Expose the unstable metadata v16#5732

Merged
lexnv merged 87 commits intomasterfrom
lexnv/metadata-v16-associated-types-enable-unstable
Nov 27, 2024
Merged

v16: Expose the unstable metadata v16#5732
lexnv merged 87 commits intomasterfrom
lexnv/metadata-v16-associated-types-enable-unstable

Conversation

@lexnv
Copy link
Copy Markdown
Contributor

@lexnv lexnv commented Sep 16, 2024 •
edited
Loading

This PR exposes the unstable metadata V16. The metadata is exposed under the unstable u32::MAX number.

Developers can start experimenting with the new features of the metadata v16. Please note that this metadata is under development and expect breaking changes until stabilization.

The ExtrinsicMetadata trait receives a breaking change. Its associated type VERSION is rename to VERSIONS and now supports a constant static list of metadata versions.
The versions implemented for UncheckedExtrinsic are v4 (legacy version) and v5 (new version).

For metadata collection, it is assumed that all TransactionExtensions are under version 0.

Builds on top of: #5274

Closes: #5980
Closes: #5347
Closes: #5285

cc @paritytech/subxt-team

lexnv added 30 commits August 7, 2024 18:05
@lexnv
metadata-ir: Introduce PalletAssociatedTypeMetadata
7e8baee 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/config: Add associated types to parsed config
1c12f15 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/expand: Implement associated types expansion
20b22d8 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/expand: Use provided cfgs for the associated types
350efce 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/construct_runtime: Extract associated types from pallet config
3e97971 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/pallet: Introduce config(without_metadata)
5d8021e 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/pallet: Introduce #[pallet::include_metadata] for associated
5679244 
types

Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/pallet: Include associated type iff bounds contain TypeInfo
958611e 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/pallet: Proper flag for metdata collection
7f26b67 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests/ui: Fix type in test
cc001f3 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests/ui: Check config without metadata
b2803e2 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests/ui: Check config with multiple attributes
94007d8 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests/ui: Add negative test for duplicate attributes in config
75d2697 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests/ui: Add negative test for collecting metadata from constants
ebcb4a0 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests/ui: Add negative test for metadata collection on events
5115021 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/tests: Check PalletAssociatedTypeMetadataIR collection
aba029a 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame/support: Add documentation
6502c83 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Add PRdoc
e9571cb 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Merge remote-tracking branch 'origin/master' into lexnv/metadata-v16-…
31bf284 
…associated-types
@lexnv
Update prdoc
7429eb7 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
prdoc: Remove unneeded crate
8a0c138 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
prdoc: Include frame-support
c6c1800 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Prupdate
90c100c 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
metadata-ir: Add v16 wrappers in preparation for frame-md release
fc87031 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Merge remote-tracking branch 'origin/master' into lexnv/metadata-v16-…
f627476 
…associated-types

Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
metadata-ir: Add conversion methods
b533f60 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
metadata-ir: Enable v16 version as unstable
e298259 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
metadata-ir: Fix into stable conversion
d0ff8f4 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
frame-md: Use git dependency instead
4060637 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
metadata-ir: Adjust for new transaction format
adf7508 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv removed request for a team November 26, 2024 10:55
@lexnv lexnv disabled auto-merge November 26, 2024 11:00
pgherveou
pgherveou approved these changes Nov 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for pallet-revive ownership

@lexnv lexnv added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@lexnv lexnv added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit 5b1b34d Nov 27, 2024
@lexnv lexnv deleted the lexnv/metadata-v16-associated-types-enable-unstable branch November 27, 2024 13:01
@lexnv lexnv mentioned this pull request Nov 27, 2024
Merged
EgorPopelyaev added a commit that referenced this pull request Nov 27, 2024
@lexnv @EgorPopelyaev
Backport/2412: Expose the unstable metadata v16 (#6676)
e607de0 
This PR is a backport for:
- #5732

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Egor_P <[email protected]>
Krayt78 pushed a commit to Krayt78/polkadot-sdk that referenced this pull request Dec 18, 2024
@lexnv @niklasad1
@bkchr @jsdw @actions-user @Krayt78
v16: Expose the unstable metadata v16 (paritytech#5732)
b8f05bf 
This PR exposes the *unstable* metadata V16. The metadata is exposed
under the unstable u32::MAX number.

Developers can start experimenting with the new features of the metadata
v16. *Please note that this metadata is under development and expect
breaking changes until stabilization.*

The `ExtrinsicMetadata` trait receives a breaking change. Its associated
type `VERSION` is rename to `VERSIONS` and now supports a constant
static list of metadata versions.
The versions implemented for `UncheckedExtrinsic` are v4 (legacy
version) and v5 (new version).

For metadata collection, it is assumed that all `TransactionExtensions`
are under version 0.

Builds on top of: paritytech#5274

Closes: paritytech#5980
Closes: paritytech#5347
Closes: paritytech#5285

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: James Wilson <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
@lexnv @niklasad1
@bkchr @jsdw @actions-user @dudo50
v16: Expose the unstable metadata v16 (paritytech#5732)
a0d7e79 
This PR exposes the *unstable* metadata V16. The metadata is exposed
under the unstable u32::MAX number.

Developers can start experimenting with the new features of the metadata
v16. *Please note that this metadata is under development and expect
breaking changes until stabilization.*

The `ExtrinsicMetadata` trait receives a breaking change. Its associated
type `VERSION` is rename to `VERSIONS` and now supports a constant
static list of metadata versions.
The versions implemented for `UncheckedExtrinsic` are v4 (legacy
version) and v5 (new version).

For metadata collection, it is assumed that all `TransactionExtensions`
are under version 0.

Builds on top of: paritytech#5274

Closes: paritytech#5980
Closes: paritytech#5347
Closes: paritytech#5285

cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: James Wilson <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
@haerdib haerdib mentioned this pull request Jan 23, 2025
Merged
@haerdib haerdib mentioned this pull request Jan 31, 2025
Open
@ashutoshvarma ashutoshvarma mentioned this pull request Apr 24, 2025
Closed
@pandres95 pandres95 mentioned this pull request May 6, 2025
Merged
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Closed
This was referenced Jul 16, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgherveou pgherveou pgherveou approved these changes

@jsdw jsdw jsdw approved these changes

@bkchr bkchr bkchr approved these changes

@xermicus xermicus xermicus approved these changes

@gui1117 gui1117 gui1117 approved these changes

@pkhry pkhry pkhry approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

@Morganamilo Morganamilo Awaiting requested review from Morganamilo

+1 more reviewer

@niklasad1 niklasad1 niklasad1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lexnv lexnv

Labels

I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

[preview] release tracker
Status: Done
Stable2412 LTS Release
Status: Done

Milestone

No milestone

9 participants

@lexnv @pgherveou @jsdw @bkchr @xermicus @gui1117 @niklasad1 @pkhry @actions-user