Merged
Conversation
AndreiEres
force-pushed
the
AndreiEres/issue5643
branch
from
239c401 to
7989ec9
Compare
AndreiEres
changed the title
AndreiEres
added
T8-polkadot
alexggh
approved these changes
Sep 30, 2024
s0me0ne-unkn0wn
approved these changes
Oct 1, 2024
Contributor
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
There was a problem hiding this comment.
I love where it's going, first we removed jaeger, then a subsystem message variant, now I eagerly await when we start to remove whole subsystems :)
paritytech-ci
pushed a commit
that referenced
this pull request
Oct 1, 2024
# Description This PR removes the `CandidateValidationMessage::ValidateFromChainState`, which was previously used by backing, but is no longer relevant since initial async backing implementation paritytech/polkadot#5557. Fixes #5643 ## Integration This change should not affect downstream projects since `ValidateFromChainState` was already unused. ## Review Notes - Removed all occurrences of `ValidateFromChainState`. - Moved utility functions, previously used in candidate validation tests and malus, exclusively to candidate validation tests as they are no longer used in malus. - Deleted the `polkadot_parachain_candidate_validation_validate_from_chain_state` metric from Prometheus. - Removed `Spawner` from `ReplaceValidationResult` in malus’ interceptors. - `fake_validation_error` was only used for `ValidateFromChainState` handling, while other cases directly used `InvalidCandidate::InvalidOutputs`. It has been replaced with `fake_validation_error`, with a fallback to `InvalidCandidate::InvalidOutputs`. - Updated overseer’s minimal example to replace `ValidateFromChainState` with `ValidateFromExhaustive`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
CandidateValidationMessage::ValidateFromChainState, which was previously used by backing, but is no longer relevant since initial async backing implementation paritytech/polkadot#5557.Fixes #5643
Integration
This change should not affect downstream projects since
ValidateFromChainStatewas already unused.Review Notes
ValidateFromChainState.polkadot_parachain_candidate_validation_validate_from_chain_statemetric from Prometheus.SpawnerfromReplaceValidationResultin malus’ interceptors.fake_validation_errorwas only used forValidateFromChainStatehandling, while other cases directly usedInvalidCandidate::InvalidOutputs. It has been replaced withfake_validation_error, with a fallback toInvalidCandidate::InvalidOutputs.ValidateFromChainStatewithValidateFromExhaustive.