Skip to content

pallet-migrations: fix index access for singluar migrations#5695

Merged
ggwpez merged 4 commits intomasterfrom
oty-pallet-migrations-fix
Sep 13, 2024
Merged

pallet-migrations: fix index access for singluar migrations#5695
ggwpez merged 4 commits intomasterfrom
oty-pallet-migrations-fix

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented Sep 12, 2024 •
edited
Loading

Discovered a bug in the migrations pallet while debugging paritytech/try-runtime-cli#90.
🚨 This can lead to your chain getting stuck. It happens when a single MBM is configured. Having no or more than one MBM will circumvent the issue.

Changes:

  • Check len of the tuple before accessing its nth_id
  • Make nth_id return None on unary tuples and n>0

@ggwpez
pallet-migrations: fix index access for singluar migrations
1d45ede 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from a team as a code owner September 12, 2024 16:10
ggwpez
ggwpez commented Sep 12, 2024
View reviewed changes
substrate/frame/support/src/migrations.rs
}

fn nth_id(_n: u32) -> Option<Vec<u8>> {
Some(T::id().encode())
Copy link
Copy Markdown
Member Author

@ggwpez ggwpez Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the actual issue

Copy link
Copy Markdown
Contributor

@georgepisaltu georgepisaltu Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and this was not overwritten for a single migration that's not part of a tuple, right?

@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented Sep 12, 2024

/cmd prdoc --pr 5695 --bump patch --audience "Runtime Dev"

@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 12, 2024
@ggwpez
doc
c35cd4c 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech paritytech deleted a comment from github-actions bot Sep 12, 2024
@paritytech paritytech deleted a comment from github-actions bot Sep 12, 2024
georgepisaltu
georgepisaltu approved these changes Sep 12, 2024
View reviewed changes
substrate/frame/support/src/migrations.rs
}

fn nth_id(_n: u32) -> Option<Vec<u8>> {
Some(T::id().encode())
Copy link
Copy Markdown
Contributor

@georgepisaltu georgepisaltu Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and this was not overwritten for a single migration that's not part of a tuple, right?

@ggwpez ggwpez enabled auto-merge September 13, 2024 10:54
@ggwpez ggwpez added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 0136463 Sep 13, 2024
@ggwpez ggwpez deleted the oty-pallet-migrations-fix branch September 13, 2024 12:17
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
02ed9b1 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
75db8ab 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
331e7ca 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

paritytech-cmd-bot-polkadot-sdk bot commented Sep 16, 2024

Git push to origin failed for stable2407 with exitcode 1

github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
8781c7a 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

paritytech-cmd-bot-polkadot-sdk bot commented Sep 16, 2024

Successfully created backport PR for stable2409:

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 16, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
b539e90 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

paritytech-cmd-bot-polkadot-sdk bot commented Sep 16, 2024

Successfully created backport PR for stable2407:

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 16, 2024
Merged
@paritytech-cmd-bot-polkadot-sdk
Copy link
Copy Markdown
Contributor

paritytech-cmd-bot-polkadot-sdk bot commented Sep 16, 2024

Git push to origin failed for stable2409 with exitcode 1

ggwpez added a commit that referenced this pull request Sep 16, 2024
@paritytech-cmd-bot-polkadot-sdk @ggwpez
[stable2409] Backport #5695 (#5728)
692daf4 
Backport #5695 into `stable2409` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez added a commit that referenced this pull request Sep 17, 2024
@paritytech-cmd-bot-polkadot-sdk @ggwpez
[stable2407] Backport #5695 (#5729)
e484c01 
Backport #5695 into `stable2407` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This was referenced Sep 24, 2024
Merged
Closed
@TDemeco TDemeco mentioned this pull request Oct 14, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Closed
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Closed
@ashutoshvarma ashutoshvarma mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

@seadanda seadanda seadanda approved these changes

@georgepisaltu georgepisaltu georgepisaltu approved these changes

+1 more reviewer

@claravanstaden claravanstaden claravanstaden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

[preview] release tracker
Status: Done
Stable2409 LTS Release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ggwpez @claravanstaden @bkchr @seadanda @georgepisaltu @pgherveou