Skip to content

sync: Remove checking of the extrinsics root #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 8 commits into from
Oct 18, 2024
Merged

sync: Remove checking of the extrinsics root #5686

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b151415
sync: Remove checking of the extrinsics root
bkchr Sep 12, 2024
48109ac
PRDOC
bkchr Sep 12, 2024
8bb158a
Merge branch 'master' into bkchr-sync-remove-extrinsics-root-check
bkchr Sep 16, 2024
14db308
Make clippy happy
bkchr Sep 24, 2024
0d49e95
Merge branch 'master' into bkchr-sync-remove-extrinsics-root-check
bkchr Sep 24, 2024
ac6363c
Merge branch 'master' into bkchr-sync-remove-extrinsics-root-check
bkchr Sep 25, 2024
3317e34
Merge branch 'master' into bkchr-sync-remove-extrinsics-root-check
bkchr Sep 26, 2024
f9f0a4f
Merge branch 'master' into bkchr-sync-remove-extrinsics-root-check
bkchr Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions substrate/client/network/sync/src/strategy/chain_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2285,24 +2285,6 @@ pub fn validate_blocks<Block: BlockT>(
return Err(BadPeer(*peer_id, rep::BAD_BLOCK));
}
}
if let (Some(header), Some(body)) = (&b.header, &b.body) {
let expected = *header.extrinsics_root();
let got = HashingFor::<Block>::ordered_trie_root(
body.iter().map(Encode::encode).collect(),
sp_runtime::StateVersion::V0,
);
if expected != got {
debug!(
target: LOG_TARGET,
"Bad extrinsic root for a block {} received from {}. Expected {:?}, got {:?}",
b.hash,
peer_id,
expected,
got,
);
return Err(BadPeer(*peer_id, rep::BAD_BLOCK));
}
}
}

Ok(blocks.first().and_then(|b| b.header.as_ref()).map(|h| *h.number()))
Expand Down